Uh oh!
There was an error while loading. Please reload this page.
HDDS-13445. Make ozone debug replicas chunk-info stream json output between datanode calls - #8914
Conversation
adoroszlai
commented
Aug 7, 2025
@Gargi-jais11 the PR description does not seem to match the actual change, and the branch references HDDS-13445, not HDDS-12998 |
ozone debug replicas chunk-info stream json output between datanode callsGargi-jais11
commented
Aug 7, 2025
So sorry. I have changed PR description. |
Uh oh!
There was an error while loading. Please reload this page.
errose28
left a comment
There was a problem hiding this comment.
Thanks for the improvement. Mostly looks good. I tested it manually as well. Just two minor comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sarvekshayr
left a comment
There was a problem hiding this comment.
Tested locally and verified the streaming output. Other than Ethan’s comments, overall LGTM.
Uh oh!
There was an error while loading. Please reload this page.
Tejaskriya
commented
Aug 26, 2025
Thanks @Gargi-jais11 for the patch, and @errose28@sarvekshayr for the reviews |
What changes were proposed in this pull request?
ozone debug replicas chunk-info prints chunk information from all replicas for all chunks of all blocks within a file. It gathers all the information from the datanodes, stores it in memory, then prints it all at once. For large files in the GB range, this could result in a large amount of information stored in the client memory before printing. It would be better to print information about one block at a time in between each getBlock call to the datanode. The Json structure can remain the same.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13445
How was this patch tested?
ran manually on docker-cluster