Skip to content

HDDS-13779. Correctly initialize the bootstrap lock in OMDBCheckpointServletInodeBasedXfer. - #9142

Merged
jojochuang merged 1 commit into
apache:masterfrom
sadanand48:HDDS-13779
Oct 14, 2025
Merged

HDDS-13779. Correctly initialize the bootstrap lock in OMDBCheckpointServletInodeBasedXfer.#9142
jojochuang merged 1 commit into
apache:masterfrom
sadanand48:HDDS-13779

Conversation

@sadanand48

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Proper initialization of bootstap lock in OMDBCheckpointServletInodeBasedXfer.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13779

How was this patch tested?

Unit tests

@sadanand48sadanand48 added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Oct 13, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes proper initialization of the bootstrap lock in OMDBCheckpointServletInodeBasedXfer to prevent concurrency issues during checkpoint operations.

  • Adds proper bootstrap lock initialization in the servlet's init() method
  • Implements the getBootstrapStateLock() method to return the lock instance
  • Adds comprehensive unit tests to verify lock coordination between checkpoint operations and background services

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
OMDBCheckpointServletInodeBasedXfer.javaAdds bootstrap lock field initialization and getter method implementation
TestOMDbCheckpointServletInodeBasedXfer.javaAdds unit tests for bootstrap lock coordination and blocking behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@swamirishiswamirishi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sadanand48 thanks for the patch

@jojochuang
jojochuang merged commit 4e5e5a0 into apache:masterOct 14, 2025
43 checks passed
@jojochuang

Copy link
Copy Markdown
Contributor

Merged. Thanks @sadanand48@swamirishi

@smengcl

Copy link
Copy Markdown
Contributor

Thanks @sadanand48 for the patch.

jojochuang added a commit to jojochuang/ozone that referenced this pull request Nov 19, 2025
jojochuang added a commit that referenced this pull request Nov 21, 2025
…eckpointServletInodeBasedXfer. (#9142)"
This reverts commit 4e5e5a0.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshothttps://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@sadanand48@jojochuang@smengcl@swamirishi