Uh oh!
There was an error while loading. Please reload this page.
HDDS-13779. Correctly initialize the bootstrap lock in OMDBCheckpointServletInodeBasedXfer. - #9142
Conversation
…ServletInodeBasedXfer.
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes proper initialization of the bootstrap lock in OMDBCheckpointServletInodeBasedXfer to prevent concurrency issues during checkpoint operations.
- Adds proper bootstrap lock initialization in the servlet's init() method
- Implements the getBootstrapStateLock() method to return the lock instance
- Adds comprehensive unit tests to verify lock coordination between checkpoint operations and background services
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| OMDBCheckpointServletInodeBasedXfer.java | Adds bootstrap lock field initialization and getter method implementation |
| TestOMDbCheckpointServletInodeBasedXfer.java | Adds unit tests for bootstrap lock coordination and blocking behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
swamirishi
left a comment
There was a problem hiding this comment.
LGTM @sadanand48 thanks for the patch
Uh oh!
There was an error while loading. Please reload this page.
jojochuang
commented
Oct 14, 2025
Merged. Thanks @sadanand48@swamirishi |
smengcl
commented
Oct 14, 2025
Thanks @sadanand48 for the patch. |
…eckpointServletInodeBasedXfer. (apache#9142)" This reverts commit 4e5e5a0.
What changes were proposed in this pull request?
Proper initialization of bootstap lock in OMDBCheckpointServletInodeBasedXfer.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13779
How was this patch tested?
Unit tests