Uh oh!
There was an error while loading. Please reload this page.
HDDS-14871. DataNode: tolerate per-volume health-check latch timeouts before marking volumes failed. - #9954
Conversation
… before marking volumes failed.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ptlrs
left a comment
There was a problem hiding this comment.
Thanks for the PR @devmadhuu
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
devmadhuu
commented
Mar 30, 2026
priyeshkaratha
left a comment
There was a problem hiding this comment.
Thanks @devmadhuu for the patch. Changes LGTM
ptlrs
commented
Apr 14, 2026
Hi @devmadhuu, #8843 has been merged. Could you please revisit this PR? |
ptlrs
left a comment
There was a problem hiding this comment.
Thanks for the update @devmadhuu. I have some comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ptlrs
left a comment
There was a problem hiding this comment.
Thank you for the updates @devmadhuu. I just have one concern about the callback. Otherwise, the code mostly looks good to me.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jojochuang
left a comment
There was a problem hiding this comment.
hi thanks a lot for the PR. I see that it has several rounds of through reviews and it's been a month. If there are no major concerns we should merge it, and fix remaining minor issues in a follow-on task.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
… markFailed method.
ptlrs
left a comment
There was a problem hiding this comment.
Thanks for the changes @devmadhuu. LGTM
Uh oh!
There was an error while loading. Please reload this page.
jojochuang
commented
Apr 23, 2026
Merged. Thanks @devmadhuu@ptlrs@ChenSammi@priyeshkaratha |
What changes were proposed in this pull request?
This PR addresses the problem of latch timeout for pending volumes not reported any result.
StorageVolumeChecker.checkAllVolumes()waits on a singleCountDownLatchfor all volume health checks to complete. If the latch expires before any volume finishes — due to any transient stall — every pending volume is immediately marked FAILED with zero tolerance, producing false-positive volume failures.The existing per-volume IO-failure sliding window in
StorageVolume.check()does not address this because it only applies when a check completes, not when the latch times out.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14871
How was this patch tested?
This patch has been tested by extending 3 unit tests in existing test class :
TestStorageVolumeHealthChecks