Uh oh!
There was an error while loading. Please reload this page.
[core] Avoid global index rebuilds for unrelated column compaction - #9069
Merged
JingsongLi merged 1 commit intoAug 20, 2026
Merged
Conversation
leaves12138force-pushed
the
codex/wip-column-sequence-metadata
branch
from
August 10, 2026 07:21
c454d0c to
32f5174Compareleaves12138force-pushed
the
codex/wip-column-sequence-metadata
branch
2 times, most recently
from
August 18, 2026 07:34
ecb805c to
c033c5eCompareleaves12138
marked this pull request as ready for review
August 19, 2026 09:35
leaves12138force-pushed
the
codex/wip-column-sequence-metadata
branch
from
August 19, 2026 09:49
9ad492b to
9208788Compareleaves12138
marked this pull request as draft
August 19, 2026 09:50
leaves12138
marked this pull request as ready for review
August 19, 2026 09:51
leaves12138
marked this pull request as draft
August 19, 2026 09:52
leaves12138
marked this pull request as ready for review
August 19, 2026 09:57
leaves12138
marked this pull request as draft
August 19, 2026 10:12
leaves12138
marked this pull request as ready for review
August 19, 2026 13:06
leaves12138
marked this pull request as draft
August 19, 2026 14:20
leaves12138
marked this pull request as ready for review
August 19, 2026 14:23
leaves12138
commented
Aug 20, 2026
ContributorAuthor
I have one question: |
JingsongLi
marked this pull request as draft
August 20, 2026 02:51
JingsongLi
commented
Aug 20, 2026
Contributor
Converted to draft, "Add an optional positional long[] of per-column maximum sequence numbers to DataFileMeta" should be a separate PR. |
leaves12138force-pushed
the
codex/wip-column-sequence-metadata
branch
from
August 20, 2026 10:16
c71a8bd to
60170e5Compareleaves12138
marked this pull request as ready for review
August 20, 2026 10:16
JingsongLi
commented
Aug 20, 2026
Contributor
+1 |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
_WRITE_COLS_SEQUENCESfield in the binary manifest path.Why
Data-evolution compaction rewrites a full normal data file. The file-level
maxSequenceNumberadvances even when only a non-index column changed, so the previous planner rebuilt an otherwise valid global index.PR #9313 persists per-column sequence watermarks in
DataFileMeta. This PR consumes those watermarks so non-index-column compaction does not trigger index work, while indexed-column updates still refresh the exact affected row range.The decision no longer depends on retained snapshot history, so it remains correct after snapshots expire and across repeated compactions.
Compatibility
CompactFileIdentifierSetpath remains unchanged for recognizing deleted files during projected manifest scans.Scope
This is the functional follow-up to merged PR #9313.
It does not change
DataFileMeta, compaction metadata generation, serializers, split protocols, orCollectedDeletes.Tests
DataEvolutionGlobalIndexRefreshPlannerTestcovers compacted full files,writeColsordering, row-tracking fields, malformed metadata fallback, and schema caching.SortedGlobalIndexScannerTestcovers sequential non-index/index-column updates with compaction, exact refresh row ranges, and snapshot expiration.GenericGlobalIndexScannerTest.