Uh oh!
There was an error while loading. Please reload this page.
[core] Encapsulate split serialization protocols - #9316
Merged
JingsongLi merged 1 commit intoAug 20, 2026
Conversation
leaves12138
marked this pull request as ready for review
August 20, 2026 07:55
leaves12138
marked this pull request as draft
August 20, 2026 08:01
leaves12138
marked this pull request as ready for review
August 20, 2026 08:03
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SplitSerializerfocused on the outer frame, stable type ids, and type dispatch.IncrementalSplitbinary serialization into publicserialize(DataOutputView)anddeserialize(DataInputView)methods, matchingDataSplit,ChainSplit, andIndexedSplit.FallbackSplitImplown its innerisFallback + wrapped splitprotocol.QueryAuthSplitown its wrapped split and authorization-result protocol.writeObject/readObjecton the complete outer frame for wrapper splits, avoiding recursive delegation while preserving their Java serialization layout.Why
SplitSerializerpreviously duplicated the field-level formats of several split implementations. Wrapper splits also delegated their ownserializemethods back toSplitSerializer, which then called split-specific helper methods.Giving each split ownership of its inner protocol removes the circular delegation and keeps format evolution next to the corresponding data structure.
SplitSerializernow only frames and dispatches split types.Compatibility
SplitSerializer.VERSIONremains1.IncrementalSplit.VERSIONremains1.IncrementalSplitis unchanged; its existing logic is extracted into reusable methods.SplitSerializerframe.split-v1-incrementalis refreshed because the outer protocol now delegates to the versioned innerIncrementalSplitpayload.Scope
This PR contains only the split serialization refactor. It does not include
DataFileMetaschema or column sequence changes from #9313.Tests
SplitSerializerTestQueryAuthSplitTestPendingSplitsCheckpointSerializerTest