Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

PARQUET-512: Add Google benchmark for performance testing - #93

Closed
xhochy wants to merge 5 commits into
apache:masterfrom
xhochy:parquet-512
Closed

PARQUET-512: Add Google benchmark for performance testing#93
xhochy wants to merge 5 commits into
apache:masterfrom
xhochy:parquet-512

Conversation

@xhochy

@xhochyxhochy commented May 1, 2016

Copy link
Copy Markdown
Member

Based on @emkornfield 's work in apache/arrow#29

Comment threadbuild-support/run-test.sh Outdated
PARQUET_TEST_ULIMIT_CORE=${PARQUET_TEST_ULIMIT_CORE:-0}
ulimit -c $PARQUET_TEST_ULIMIT_CORE
ARROW_TEST_ULIMIT_CORE=${ARROW_TEST_ULIMIT_CORE:-0}
ulimit -c $ARROW_TEST_ULIMIT_CORE

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buglet from Arrow porting

@wesm

wesm commented May 1, 2016

Copy link
Copy Markdown
Member

Will review the benchmark code a bit later. Can you update the Travis CI config to only run the unit tests?

@xhochy

Copy link
Copy Markdown
MemberAuthor

Benchmarks are now build but not run.

Comment thread.travis.yml Outdated
before_script:
- source $TRAVIS_BUILD_DIR/ci/before_script_travis.sh
- cmake -DCMAKE_CXX_FLAGS="-Werror" -DPARQUET_TEST_MEMCHECK=ON -DPARQUET_GENERATE_COVERAGE=1 $TRAVIS_BUILD_DIR
- cmake -DCMAKE_CXX_FLAGS="-Werror" -DPARQUET_TEST_MEMCHECK=ON -DARROW_BUILD_BENCHMARKS=ON -DPARQUET_GENERATE_COVERAGE=1 $TRAVIS_BUILD_DIR

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy and paste bug?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 😢

@wesm

wesm commented May 2, 2016

Copy link
Copy Markdown
Member

+1, thank you

@asfgitasfgit closed this in ff14d97May 2, 2016
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@xhochy@wesm@emkornfield