Skip to content

Format: Do not shade slf4j-api #266

Description

@asfimport

PARQUET-369 fixed warnings from shading slf4j-api, but a consequence of shading is that the log messages from thrift for parquet-format classes are dropped. This was an accepted trade-off until PARQUET-305 changed logging in the rest of the library to SLF4J. Now that the slf4j-api is a dependency for all of Parquet except parquet-format, it no longer makes sense to suppress the format thrift logs to avoid exposing it.

This also requires PARQUET-371 because thrift 0.7.0 relies on a very old version of slf4j-api.

Reporter: Ryan Blue / @rdblue
Assignee: Julien Le Dem / @julienledem

Related issues:

PRs and other links:

Note: This issue was originally created as PARQUET-412. Please see the migration documentation for further details.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions