Skip to content

PARQUET-1136: Fix path to parquet.thrift in Makefile - #73

Closed
lekv wants to merge 1 commit into
apache:masterfrom
lekv:makefile
Closed

PARQUET-1136: Fix path to parquet.thrift in Makefile#73
lekv wants to merge 1 commit into
apache:masterfrom
lekv:makefile

Conversation

@lekv

@lekv lekv commented Oct 11, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@lekv

lekv commented Oct 12, 2017

Copy link
Copy Markdown
Contributor Author

@rdblue - Should we try to get this into the upcoming RC?

@rdblue

rdblue commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

Yeah, I'll merge it. Thanks!

@rdblue

rdblue commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

+1

@asfgit asfgit closed this in 65f1057 Oct 12, 2017
@rdblue

rdblue commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

We may want to follow up with an update for Travis CI that runs this. Thanks for the fix, @lekv!

@lekv

lekv commented Oct 12, 2017

Copy link
Copy Markdown
Contributor Author

@rdblue - If you point me to where Travis lives, I can have a look at that.

@rdblue

rdblue commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

It is configured with .travis.yml

@lekv

lekv commented Oct 12, 2017

Copy link
Copy Markdown
Contributor Author

Cool. I created PARQUET-1137 and I have a patch that runs "make" from pom.xml during the tests. I'll create a PR once #72 has been submitted since they conflict.

@asfimport asfimport mentioned this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants