ThriftReadSupport#THRIFT_COLUMN_FILTER_KEY was removed (incompatible change)

[asfimport]

This renames, and so removes, a public field. It could possibly break apps.

Reporter: Ashish Singh / @SinghAsDev
Assignee: Ashish Singh / @SinghAsDev

Related issues:

• Release Parquet 1.8.0 (blocks)

PRs and other links:

• PR

_{Note: This issue was originally created as PARQUET-329. Please see the migration documentation for further details.}

[asfimport]

Ashish Singh / @SinghAsDev:
@rdblue, @isnotinvain what do you guys think?

[asfimport]

Ryan Blue / @rdblue:
Yes, I think this is an incompatible change. Plus, the setProjectionPushdown method at the end of ThriftReadSupport has been removed. That's definitely incompatible.

@SinghAsDev, why wasn't this caught by semver?

[asfimport]

Ryan Blue / @rdblue:
Marking as a blocker for 1.8.0. Thanks for catching this before it was released, Ashish!

[asfimport]

Ashish Singh / @SinghAsDev:
[~blue@cloudera.com] the removed method was added back in later semver restore PR. I am not sure why semver did not catch this, but I will take a look at it.

[asfimport]

Ashish Singh / @SinghAsDev:
@rdblue looks like everything in o.a.parquet.hadoop.thrift is excluded for semver checks, here. Should this be removed?

[asfimport]

Ryan Blue / @rdblue:
I don't think that's correct. The read support should be part of the public API because we have public methods, like setProjectionPushdown there. @julienledem or @tsdeng, do you agree that the ThriftReadSupport is public?

[asfimport]

Ryan Blue / @rdblue:
I've merged Ashish's fix because it isn't intrusive, just a variable rename. I've also gone ahead with the patch to remove o.a.p.hadoop.thrift from the exclusion list. It is currently compatible, so we can check compatibility and determine whether this is public later, though I'm pretty sure it is public API.