Skip to content

Fix flush() for RecordConsumer and implementations #1941

Description

@asfimport

+flush()+ was added in +RecordConsumer+ and +MessageColumnIO+ to help implementing nulls caching.

However, other +RecordConsumer+ implementations should also implements +flush()+ properly. For instance, +RecordConsumerLoggingWrapper+ and +ValidatingRecordConsumer+ should call +delegate.flush()+ in their +flush()+ methods, otherwise data might be mistakenly truncated.

This ticket:

  • makes +flush()+ abstract in +RecordConsumer+
  • implements +flush()+ properly for all +RecordConsumer+ subclasses, specifically:
    • +RecordConsumerLoggingWrapper+
    • +ValidatingRecordConsumer+
    • +ConverterConsumer+
    • +ExpectationValidatingRecordConsumer+

Reporter: Liwei Lin(Inactive) / @lw-lin
Assignee: Liwei Lin(Inactive) / @lw-lin

Related issues:

PRs and other links:

Note: This issue was originally created as PARQUET-528. Please see the migration documentation for further details.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions