Skip to content

jackson-parquet doesn't shade ServiceLoader discovery files #3253

Description

@LDVSOFT

Describe the bug, including details regarding any error messages, version, and platform.

If you peek inside parquet-jackson jar you can easily find under META-INF/services/ a couple of services like META-INF/services/com.fasterxml.jackson.core.JsonFactory. Both the offered service name and implementing classes inside aren't shaded.

This doesn't seem to break the code itself, but does raise a couple of concerns:

  1. If there is a need in offering services in shaded Jackson, those should be fixed.
  2. If there is no such need those can be skipped not to interfere with non-shaded Jackson (however the effect here is minimal, besides just duplicating an entry).

For example, AWS SDK for Java v2 rewrites their services file from Jackson core.

Checked on 1.13.1 and 1.15.2.

Component(s)

Build

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions