Skip to content

Removing word "Incubating" from project - #184

Closed
lukasnalezenec wants to merge 2 commits into
apache:masterfrom
lukasnalezenec:incubating
Closed

Removing word "Incubating" from project#184
lukasnalezenec wants to merge 2 commits into
apache:masterfrom
lukasnalezenec:incubating

Conversation

@lukasnalezenec

Copy link
Copy Markdown
Contributor

No description provided.

…quet file using parquet-protobuf.

 Changes to be committed:
	modified:   parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoReadSupport.java
	modified:   parquet-protobuf/src/test/java/org/apache/parquet/proto/ProtoInputOutputFormatTest.java
	modified:   parquet-protobuf/src/test/resources/TestProtobuf.proto

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an unrelated change?

@julienledem

Copy link
Copy Markdown
Member

overall this looks good to me except for the unrelated change.
please get PR reviewed by another committer before merging.
otherwise, thanks for cleaning up.

@lukasnalezenec

Copy link
Copy Markdown
Contributor Author

Hi,
I have closed this PR without merging because Ryan Blue opened similar pull request 186 few hours after this one. The unrelated changes were caused by wrong git branching.

#186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants