Uh oh!
There was an error while loading. Please reload this page.
GH-3168: Restrict trusted packages in the parquet-avro module - #3169
Merged
Conversation
gszadovszky
commented
Mar 5, 2025
Contributor
@wgtmac, seems you'll need to extend the list in some unit tests. |
wgtmac
commented
Mar 5, 2025
MemberAuthor
@gszadovszky It should be fixed now :) |
wgtmacforce-pushed
the
restrict_avro_package
branch
from
March 6, 2025 01:30
f0160bd to
664ce2bComparegszadovszky
commented
Mar 6, 2025
Contributor
@wgtmac, thanks for dealing with this. I think we should have a negative test for it. |
rdblue
approved these changes
Mar 6, 2025
wgtmacforce-pushed
the
restrict_avro_package
branch
from
March 7, 2025 08:08
c8656e7 to
7caf4b5Comparewgtmac
commented
Mar 7, 2025
MemberAuthor
@gszadovszky@rdblue Thanks for your review! I've added a test case. |
dongjoon-hyun
commented
Mar 7, 2025
Member
Thank you all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See the Avro parity: apache/avro#2934
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Closes#3168