Conversation
This commit fixes an issue when the number of entries in a column page is larger than the size of an integer. No exception is thrown directly, but the def level is set incorrectly, leading to a null value being returned during read.
| this.totalValueCount = pageReader.getTotalValueCount(); | ||
| if (totalValueCount == 0) { | ||
| if (totalValueCount <= 0) { | ||
| throw new ParquetDecodingException("totalValueCount == 0"); |
Contributor
There was a problem hiding this comment.
I would also change the error message here to provide the value of totalValueCount (and change the equality)
Member
|
looks good to me |
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
This commit fixes an issue when the number of entries in a column page is larger than the size of an integer. No exception is thrown directly, but the def level is set incorrectly, leading to a null value being returned during read. Author: Michal Gorecki <goreckim@amazon.com> Closes apache#321 from goreckm/int-overflow and squashes the following commits: d224815 [Michal Gorecki] enhancing exception message 7334be2 [Michal Gorecki] PARQUET-511: Integer overflow when counting values in column.
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 10, 2017
This commit fixes an issue when the number of entries in a column page is larger than the size of an integer. No exception is thrown directly, but the def level is set incorrectly, leading to a null value being returned during read. Author: Michal Gorecki <goreckim@amazon.com> Closes apache#321 from goreckm/int-overflow and squashes the following commits: d224815 [Michal Gorecki] enhancing exception message 7334be2 [Michal Gorecki] PARQUET-511: Integer overflow when counting values in column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue when the number of entries in a column page is larger than the size of an integer. No exception is thrown directly, but the def level is set incorrectly, leading to a null value being returned during read.