Uh oh!
There was an error while loading. Please reload this page.
GH-3233: Parquet CLI supports version command - #3234
Conversation
wgtmac
commented
Jun 3, 2025
Isn't it already displayed by the |
pan3793
commented
Jun 3, 2025
@wgtmac it's a different thing, |
wgtmac
commented
Jun 3, 2025
Ah, thanks for the clarification! Since this is a parameter for the tool itself, what about following style of the help command like below? Perhaps we need to add alias |
pan3793
commented
Jun 3, 2025
@wgtmac |
| @Override | ||
| public List<String> getExamples() { | ||
| return null; |
There was a problem hiding this comment.
nit: probably doesn't matter much, but other commands without examples return empty array list instead of null (Lists.newArrayList() or maybe even better Collections.EMPTY_LIST)
There was a problem hiding this comment.
Thanks for taking a look, I copied it from Help#getExamples. Anyway, avoiding NULL propagation is generally a good idea, let me update both.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Rationale for this change
Follow the convention for the CLI tools to add a
versioncommand.What changes are included in this PR?
As title.
Are these changes tested?
UT added, also tested manually
Are there any user-facing changes?
Yes.
Closes#3233