Uh oh!
There was an error while loading. Please reload this page.
GH-3239: Improve ByteBufferReadable detection in HadoopStream - #3259
Merged
Conversation
wangyum
commented
Jul 29, 2025
MemberAuthor
wgtmac
approved these changes
Jul 29, 2025
wgtmac
left a comment
Member
There was a problem hiding this comment.
Looks good to me as we are already on Hadoop 3.3.0.
Do you have any concern? @gszadovszky@Fokko
nandorKollar
approved these changes
Jul 30, 2025
steveloughran
approved these changes
Jul 30, 2025
steveloughran
left a comment
Contributor
There was a problem hiding this comment.
always good to get rid of needless reflection.
I think I noted in some other jira that the reflection code was broken too, it was looking for hasCapabilities when it needed hasCapability , so it'd never get found. This PR fixes that with compile-time checking
Uh oh!
There was an error while loading. Please reload this page.
wgtmac
commented
Jul 31, 2025
Member
Merged. Thanks everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
ByteBufferReadabledetection inHadoopStreamsby checking for the "in:readbytebuffer" capability using thehasCapabilitymethod instead ofhasCapabilitiesinFSDataInputStream.