Skip to content

GH-3290: Restore Snapshot versions for vector/benchmark modules - #3288

Merged
gszadovszky merged 2 commits into
apache:masterfrom
ArnavBalyan:arnavb/test-build
Aug 29, 2025
Merged

GH-3290: Restore Snapshot versions for vector/benchmark modules#3288
gszadovszky merged 2 commits into
apache:masterfrom
ArnavBalyan:arnavb/test-build

Conversation

@ArnavBalyan

@ArnavBalyanArnavBalyan commented Aug 29, 2025

Copy link
Copy Markdown
Member
  • 1.16 release process did not revert back the snapshot versions correctly.
  • This caused the main to have inconsistent dependencies/ possible build failures.
  • Since the versions are listed as additional profiles and not in the module list by default, we should probably configure a maven release plugin which can include them through custom rules. Will add support as a followup.
  • FixesCI broke after release process #3290

@ArnavBalyanArnavBalyan changed the title DNM - Fixing CIRestor Snapshot versions for vector/benchmark modulesAug 29, 2025
@ArnavBalyanArnavBalyan changed the title Restor Snapshot versions for vector/benchmark modulesRestore Snapshot versions for vector/benchmark modulesAug 29, 2025
@ArnavBalyan

ArnavBalyan commented Aug 29, 2025

Copy link
Copy Markdown
MemberAuthor

cc @gszadovszky@wgtmac looks like the latest master CI and some builds were failing, release script probably did not restore everything back to snapshot versions, could you pls take a look

@ArnavBalyanArnavBalyan changed the title Restore Snapshot versions for vector/benchmark modulesGH-3290: Restore Snapshot versions for vector/benchmark modulesAug 29, 2025

@gszadovszkygszadovszky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArnavBalyan for fixing this

@gszadovszky
gszadovszky merged commit 4591ed3 into apache:masterAug 29, 2025
7 checks passed
@wgtmac

Copy link
Copy Markdown
Member

Thanks for catching this! I think we need to bump to 1.17.0-SNAPSHOT, right?

@ArnavBalyan

ArnavBalyan commented Aug 29, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks for catching this! I think we need to bump to 1.17.0-SNAPSHOT, right?

Yes, right now the whole repo is on 1.16.0-SNAPSHOT and consistent, it should probably be safe to bump up if the release was successful, @wgtmac if 1.16 was successful I can update everything to 1.17.0-SNAPSHOT let me know. will check why mvn release did not do it for us.

@ArnavBalyan

Copy link
Copy Markdown
MemberAuthor

Thanks! If it looks ok to you have bumped up here: #3293

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI broke after release process

3 participants

@ArnavBalyan@wgtmac@gszadovszky