GH-3224: Make ParquetProperties.valuesWriterFactory thread safe

[ArnavBalyan]

Rationale for this change

• Move away from shared singleton DEFAULT_VALUES_WRITER_FACTORY to new instance per builder to prevent concurrent threads from corrupting each other's delegateFactory state.
• Currently there is a bug where multiple builders can corrupt each others delegateFactory that can cause files to get written with wrong format.
• Since valuesWriterFactory.initialize() uses the singleton state which can be altered by another writer thread.
• Fixes: ParquetProperties.valuesWriterFactory is not thread-safe #3224
• Added UT to ensure multiple builders dont share the same ValuesWriterFactory state.

Are these changes tested?

• Yes

Are there any user-facing changes?

• Partially

Closes: #3224

[ArnavBalyan]

cc @gszadovszky thanks! :)

[gszadovszky]

Thanks for working on this, @ArnavBalyan.
Unfortunately, ParquetProperties.DEFAULT_VALUES_WRITER_FACTORY is public. But at least, we should deprecate it.

[ArnavBalyan]

Thanks for working on this, @ArnavBalyan. Unfortunately, ParquetProperties.DEFAULT_VALUES_WRITER_FACTORY is public. But at least, we should deprecate it.

Ack thanks, have marked the method as deprecated. Did you also mean to remove the change altogether and just mark it deprecated with a comment?

[gszadovszky]

Did you also mean to remove the change altogether and just mark it deprecated with a comment?

No, the change looks good to me now.