Uh oh!
There was an error while loading. Please reload this page.
GH-3338: Support encrypted files for Parquet CLI commands - #3339
Conversation
ArnavBalyan
commented
Sep 29, 2025
cc @gszadovszky@shangxinli could you pls take a look thanks! |
| @Parameter( | ||
| names = {"--footer-key"}, | ||
| description = "Footer key for encrypted files (hex string, 16/24/32 bytes)") | ||
| String footerKeyHex; | ||
| @Parameter( | ||
| names = {"--column-key"}, | ||
| description = "Column key for encrypted files (hex string, 16/24/32 bytes)") | ||
| String columnKeyHex; | ||
There was a problem hiding this comment.
@ArnavBalyan, is it only bloom filters? Shouldn't we add this at a more common level, so other commands would also benefit from it?
There was a problem hiding this comment.
Moved this to base, any CLI command can leverage this. I tested and supported 3 commands for now.
Will add UTs and support for the remaining CLI commands shortly. Each command should now be able to read without duplication
| @Parameter( | ||
| names = {"--column-key"}, | ||
| description = "Column key for encrypted files (hex string, 16/24/32 bytes)") | ||
| String columnKeyHex; |
There was a problem hiding this comment.
Cannot the column key be different for each column?
There was a problem hiding this comment.
Ah good point, updated to follow the existing key format within PropertiesDrivenCryptoFactory
cf06df8 to
6024701Compare
gszadovszky
left a comment
There was a problem hiding this comment.
This is a great improvement! Thanks, @ArnavBalyan.
ArnavBalyan
commented
Oct 7, 2025
cc @gszadovszky could you please merge if all looks good thanks! |
gszadovszky
commented
Oct 8, 2025
Thanks for pinging, sorry for the delay. |
Uh oh!
There was an error while loading. Please reload this page.
Rationale for this change
Are these changes tested?
Are there any user-facing changes?
Closes: #3338