Uh oh!
There was an error while loading. Please reload this page.
GH-3618: Migrate parquet-hadoop to JUnit5 - #3676
Merged
Merged
Conversation
nastraforce-pushed
the
junit5-parquet-hadoop
branch
from
July 21, 2026 09:40
ee2ebf2 to
56edef3Comparenastra
commented
Jul 21, 2026
| import org.junit.jupiter.params.provider.MethodSource; | ||
| public class TestAdaptiveBlockSplitBloomFiltering extends TestBloomFiltering { | ||
| public class TestAdaptiveBlockSplitBloomFiltering { |
ContributorAuthor
There was a problem hiding this comment.
refactoring this test is unfortunately more involved, so I opted for just using the TestBloomFiltering as an instance
nastraforce-pushed
the
junit5-parquet-hadoop
branch
from
July 21, 2026 10:10
56edef3 to
540dad0Comparenastra
commented
Jul 21, 2026
ContributorAuthor
nastraforce-pushed
the
junit5-parquet-hadoop
branch
from
July 21, 2026 10:58
540dad0 to
28d7b99Comparewgtmac
approved these changes
Jul 22, 2026
Uh oh!
There was an error while loading. Please reload this page.
wgtmac
commented
Jul 22, 2026
Member
Awesome. Thanks @nastra! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This migrates the parquet-hadoop module to JUnit5. JUnit5 doesn't support built-in class-level test parameterization and so those tests were converted to parameterize at the method level.
Closes#3618
What changes are included in this PR?
migration of parquet-hadoop to JUnit5
Are these changes tested?
yes, existing tests
Are there any user-facing changes?
no