Skip to content

PARQUET-1496: Update Scala to 2.12 - #605

Closed
xhochy wants to merge 1 commit into
apache:masterfrom
xhochy:PARQUET-1496
Closed

PARQUET-1496: Update Scala to 2.12#605
xhochy wants to merge 1 commit into
apache:masterfrom
xhochy:PARQUET-1496

Conversation

@xhochy

Copy link
Copy Markdown
Member

This sadly fails in parquet-scrooge with:

Exception parsing: /Users/uwe/Development/parquet-mr/parquet-scrooge/target/generated-resources/parquet.thrift: [510.1] failure: string matching regex `[A-Za-z_][A-Za-z0-9\._]*' expected but `}' found

This is because scrooge seems to be unable to parse the unfinished IndexPageHeader Thrift definition.

@rdblue

Copy link
Copy Markdown
Contributor

Is parquet-scala useful without parquet-scrooge? I'm wondering if we should just remove it.

<groupId>com.twitter</groupId>
<artifactId>scrooge-core_${scala.binary.version}</artifactId>
<version>4.7.0</version>
<version>19.1.0</version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy could you please upgrade scrooge version to 19.9.0? It includes a fix for the String type related issue which we experience in the latest build.

@Fokko

Copy link
Copy Markdown
Contributor

@xhochy I took the liberty of moving this ticket forward in #693

Hope you don't mind :-)

@xhochy

Copy link
Copy Markdown
MemberAuthor

@Fokko Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@xhochy@rdblue@Fokko@nandorKollar