Uh oh!
There was an error while loading. Please reload this page.
Added AES-256 encrypted parquet generated from parquet-java - #102
Merged
Conversation
hsiang-c
marked this pull request as ready for review
February 19, 2026 01:16
hsiang-c
commented
Feb 19, 2026
ContributorAuthor
cc @adamreeve |
adamreeve
commented
Feb 19, 2026
Contributor
Thanks @hsiang-c! Can you please update the data/README.md file and document the keys that have been used in these files? There's an existing section about the encrypted files at https://github.com/apache/parquet-testing/blob/master/data/README.md#encrypted-files |
Contributor
I've checked I can read these files with C++ Parquet. How annoying would it be to make the data match what's in the existing encrypted files in this repository? It would greatly simplify adding a C++ test for these if the data is the same, then I could reuse the existing test functions, but it's probably OK if the data is different. |
ContributorAuthor
@adamreeve Thanks for the pointer, I'll try to reproduce matched data. |
ContributorAuthor
I generated the test data again using a modified Parquet Java's schema (see below) and publicstaticfinalStringBOOLEAN_FIELD_NAME = "boolean_field";
publicstaticfinalStringINT32_FIELD_NAME = "int32_field";
publicstaticfinalStringINT64_FIELD_NAME = "int64_field";
publicstaticfinalStringINT96_FIELD_NAME = "int96_field";
publicstaticfinalStringFLOAT_FIELD_NAME = "float_field";
publicstaticfinalStringDOUBLE_FIELD_NAME = "double_field";
publicstaticfinalStringBINARY_FIELD_NAME = "ba_field";
publicstaticfinalStringFIXED_LENGTH_BINARY_FIELD_NAME = "flba_field";
privatestaticfinalMessageTypeSCHEMA = newMessageType(
"schema",
newPrimitiveType(REQUIRED, BOOLEAN, BOOLEAN_FIELD_NAME),
Types.required(INT32).as(LogicalTypeAnnotation.timeType(true, MILLIS)).named(INT32_FIELD_NAME),
newPrimitiveType(REPEATED, INT64, INT64_FIELD_NAME),
Types.required(INT96).named(INT96_FIELD_NAME),
newPrimitiveType(REQUIRED, FLOAT, FLOAT_FIELD_NAME),
newPrimitiveType(REQUIRED, DOUBLE, DOUBLE_FIELD_NAME),
newPrimitiveType(OPTIONAL, BINARY, BINARY_FIELD_NAME),
Types.required(FIXED_LEN_BYTE_ARRAY).length(FIXED_LENGTH).named(FIXED_LENGTH_BINARY_FIELD_NAME));Please give it a try, thanks. |
adamreeve
commented
Mar 1, 2026
Contributor
Thanks @hsiang-c. It looks like the new data is very close to what's in the existing files but the int96 timestamp values are different. I get differences for that column if I try to use the C++ test utilities: I can't see where this comes from in the Java code, it looks like it's not part of On the C++ side this column is generated by And can you also please add a note about the encryption keys used to the README (https://github.com/apache/parquet-testing/blob/master/data/README.md#encrypted-files). I've pushed a branch with my changes to C++ parquet to apache/arrow@main...adamreeve:arrow:test_aes256_keys (probably needs some refactoring before I could make a PR with this, but it's enough to test the files). |
adamreeve
commented
Mar 3, 2026
Contributor
I still see some differences in the int96 column, it looks like an endianness difference? |
hsiang-c
commented
Mar 3, 2026
ContributorAuthor
@adamreeve Sorry about that, fixed endianness now. |
adamreeve
commented
Mar 4, 2026
Contributor
(I don't have write permissions in this repository though, maybe @alamb can take a look) |
wgtmac
commented
Mar 4, 2026
Member
ggershinsky
approved these changes
Mar 4, 2026
ggershinsky
left a comment
Contributor
There was a problem hiding this comment.
Thanks @hsiang-c and @adamreeve
hsiang-c
commented
Mar 4, 2026
ContributorAuthor
Thank you @adamreeve and @ggershinsky@wgtmac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
AES_256_GCMalgorithm in [parquet] Allow more encryption algorithms arrow-rs#9203Data Preparation
withPageWriteChecksumEnabled(false)so that arrow-rs can read it w/o issue.