Skip to content

PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata - #1030

Merged
gjacoby126 merged 1 commit into
apache:masterfrom
gjacoby126:PHOENIX-5435-master
Dec 22, 2020
Merged

PHOENIX-5435 - Annotate HBase WALs with Phoenix Metadata#1030
gjacoby126 merged 1 commit into
apache:masterfrom
gjacoby126:PHOENIX-5435-master

Conversation

@gjacoby126

Copy link
Copy Markdown
Contributor

No description provided.

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 43sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 3 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep4m 55sMaven dependency ordering for branch
+1 💚mvninstall9m 57smaster passed
+1 💚compile1m 17smaster passed
+1 💚checkstyle10m 2smaster passed
+1 💚javadoc2m 29smaster passed
+0 🆗spotbugs0m 30sphoenix-hbase-compat-2.3.0 in master has 1 extant spotbugs warnings.
+0 🆗spotbugs0m 26sphoenix-hbase-compat-2.2.1 in master has 1 extant spotbugs warnings.
+0 🆗spotbugs0m 28sphoenix-hbase-compat-2.1.6 in master has 1 extant spotbugs warnings.
+0 🆗spotbugs2m 53sphoenix-core in master has 972 extant spotbugs warnings.
+0 🆗spotbugs3m 42sroot in master has 1021 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall7m 24sthe patch passed
+1 💚compile1m 15sthe patch passed
+1 💚cc1m 15sthe patch passed
+1 💚javac1m 15sthe patch passed
-1 ❌checkstyle10m 21sroot: The patch generated 552 new + 22558 unchanged - 232 fixed = 23110 total (was 22790)
+1 💚prototool0m 2sThere were no new prototool issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc2m 28sthe patch passed
-1 ❌spotbugs3m 10sphoenix-core generated 1 new + 972 unchanged - 0 fixed = 973 total (was 972)
-1 ❌spotbugs4m 6sroot generated 1 new + 1021 unchanged - 0 fixed = 1022 total (was 1021)
_ Other Tests _
-1 ❌unit106m 27sroot in the patch failed.
-1 ❌asflicense1m 53sThe patch generated 1 ASF License warnings.
185m 54s
ReasonTests
FindBugsmodule:phoenix-core
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 343]
FindBugsmodule:root
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.CHANGE_DETECTION_ENABLED_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 343]
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1030
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool
unameLinux 5d600763565e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 1dcb749
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/new-spotbugs-root.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/testReport/
asflicensehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count6852 (vs. ulimit of 30000)
modulesC: phoenix-hbase-compat-2.3.0 phoenix-hbase-compat-2.2.1 phoenix-hbase-compat-2.1.6 phoenix-core . U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1030/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@gjacoby126

Copy link
Copy Markdown
ContributorAuthor

Merging as this is a port of a previously reviewed PR (#913 ) to the master branch

@gjacoby126
gjacoby126 merged commit 9e58989 into apache:masterDec 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gjacoby126@stoty