Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6339 Older client using aggregate queries shows incorrect res… - #1111
Merged
Conversation
stoty
commented
Jan 26, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
jpisaac
reviewed
Jan 26, 2021
jpisaac
left a comment
Contributor
There was a problem hiding this comment.
Some request for comments, otherwise LGTM.
| public static long getPageSizeMsForRegionScanner(Scan scan) { | ||
| return (long) (getPageSizeMs(scan) * 0.6); | ||
| } | ||
| public static long getPageSizeMsForRegionScanner(Scan scan) { return getPageSizeMs(scan, 0.6); } |
Contributor
There was a problem hiding this comment.
What is/should be the thought process in choosing the factor? May be good to add some comments around it?
ContributorAuthor
There was a problem hiding this comment.
The comments are just right there before getPageSizeMs()
jpisaac
approved these changes
Jan 26, 2021
yanxinyi
approved these changes
Jan 26, 2021
yanxinyi
left a comment
Contributor
There was a problem hiding this comment.
downloaded the patch and built/tested it locally against the 4.15 client.
LGTM +1
abhishek-chouhan
approved these changes
Jan 27, 2021
ChinmaySKulkarni
approved these changes
Jan 27, 2021
ChinmaySKulkarni
left a comment
Contributor
There was a problem hiding this comment.
+1, thanks @kadirozde
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ults