Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6350: Fix build failure due to jakarta.xml.bind api - #1121
Closed
surnaik wants to merge 3 commits into
Closed
PHOENIX-6350: Fix build failure due to jakarta.xml.bind api#1121surnaik wants to merge 3 commits into
surnaik wants to merge 3 commits into
Conversation
stoty
commented
Jan 29, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
| <dependency> | ||
| <groupId>jakarta.xml.bind</groupId> | ||
| <artifactId>jakarta.xml.bind-api</artifactId> | ||
| <version>2.3.2</version> |
Contributor
There was a problem hiding this comment.
Can you please define this dependency version on parent pom?
Contributor
There was a problem hiding this comment.
We already depend on javax.xml.bind:bind-api.
We should probably replace that dependency, instead of adding a new one.
ContributorAuthor
There was a problem hiding this comment.
Thanks for the review guys. Sure, I'll update the PR.
Contributor
There was a problem hiding this comment.
Replacing the dependeny doesn't actually work, unfortunately.
Contributor
There was a problem hiding this comment.
This is dependency-plugin getting even more confused than usual by multiple sources of jaxb-api.
As pulling in the same set of classes from two packages just to appease dependecy plugin is not the way to go, we should just ignore this.
Contributor
There was a problem hiding this comment.
By ignore this, I mean tell dependeny-plugin to ignore these packages.
stoty
commented
Feb 3, 2021
Contributor
Alternative fix with dependency-plugin ignore setting at #1127 |
surnaik
commented
Feb 3, 2021
ContributorAuthor
@stoty, I added the jakarta xml bind to ignore used undeclared dependency |
surnaik
commented
Feb 3, 2021
ContributorAuthor
Oh, didn't see your PR, should I close this? |
surnaik
commented
Feb 3, 2021
ContributorAuthor
Please close this if not required. Thank you! |
surnaik
commented
Feb 3, 2021
ContributorAuthor
Closing this, #1127 covers this. Thanks @virajjasani and @stoty |
stoty
commented
Feb 3, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.