Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty - #1122
Closed
stoty wants to merge 2 commits into
Closed
Conversation
stoty
commented
Jan 29, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
joshelser
commented
Jan 29, 2021
Member
Is it possible to write an enforcer rule to prevent imports of the non-shaded commons-cli packages? I think HBase has something you can copy (if you don't already know how to do this off the top of your head) |
This is a test version that depends on phoenix-thirdparty 1.1.0-SNAPSHOT
stoty
commented
Jan 29, 2021
ContributorAuthor
Yes, Viraj has just added the feature a few weeks ago. |
stoty
commented
Jan 29, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
| <hbase.thirdparty.version>2.2.1</hbase.thirdparty.version> | ||
| <phoenix.thirdparty.version>1.0.0</phoenix.thirdparty.version> | ||
| <phoenix.thirdparty.version>1.1.0-SNAPSHOT</phoenix.thirdparty.version> |
Contributor
There was a problem hiding this comment.
we will replace the release version after the phoenix 3rd party release right?
should we wait and then merge this?
ContributorAuthor
There was a problem hiding this comment.
We shouldn't release 4.16/5.1with snapshot dependecies.
We can either merge this now, and update when we release thirdparty 1.1.0, or we can wait with the merge until we have 1.1.0 final.
I'm going to prepare an rc0 for thirdparty this weekend.
Contributor
There was a problem hiding this comment.
@stoty if it follows the same step, I can release the thirdparty this in my time zone today.
ContributorAuthor
There was a problem hiding this comment.
I will do publish rc0 and send out the mail in an hour.
According to the ASF rules, we must leave at least 72 hours for a release vote.
If we take that literally, and count the weekend in, then we can do the official release on Monday afternoon PT.
Contributor
There was a problem hiding this comment.
sounds great! Thanks again for the contribution!
yanxinyi
approved these changes
Jan 29, 2021
stoty
commented
Jan 29, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
virajjasani
approved these changes
Jan 30, 2021
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
+1 (non-binding), only pending change is dropping -SNAPSHOT after release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an test version the finle one needs to set thirdpart-version to 1.1.0