Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6349 Add and use commons-cli to phoenix-thirdparty - #1123
Closed
stoty wants to merge 1 commit into
Closed
Conversation
stoty
commented
Jan 29, 2021
ContributorAuthor
stoty
commented
Jan 29, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
yanxinyi
commented
Jan 30, 2021
Contributor
Huh, I'm not sure if this is my local setting issue or something else. With my local HBase setup, I tried 4.14.3 and 4.15 server jars without any issues when I called ./hbase org.apache.phoenix.mapreduce.index.IndexTool @stoty did you verify it locally? I guess the ITs are not using the server patch so it's very hard to catch the issue... |
stoty
commented
Jan 30, 2021
ContributorAuthor
No I didn't test it, I didn't have the time set up a 4.x pseudo-distributed cluster yesterday. I just keep forgetting that you need to add everything to the 4.x server jar manually Can you re-test with the updated patch @yanxinyi ? |
Contributor
Huh, I'm getting the same error. When I compared the 4.x and master server jars, the master branch server jar does have dependent classes but not 4.x. Here is the list |
This is a test version that depends on phoenix-thirdparty 1.1.0-SNAPSHOT
stoty
commented
Jan 30, 2021
ContributorAuthor
The difference is normal. In the 4.x server jar we add the shaded packages manually, and do not relocate. (Don't know why, probably historical reasons) In 4.x HEAD we don't add commons-cli, and use whatever HBase/Hadoop classpatch gives us. In master HEAD we add and shade every dependecy that isn't excluded and provided With this (updated) patch we add the org.apache.phoenix.thirdparty.org.apache.commons.cli classes on either branch. I've just run a test locally on the Phoenix 5 pseudodistributed cluster with this patch, and didn't get any errors. I am quite baffled why the same setup would cause problems on 4.x |
ContributorAuthor
I found the problem. Can you try yet again on 4.x with the now-really-fixed-i-swear patch @yanxinyi ? |
yanxinyi
commented
Jan 30, 2021
Contributor
Sure @stoty |
stoty
commented
Jan 30, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
virajjasani
approved these changes
Jan 30, 2021
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
+1 (non-binding), only pending change is dropping -SNAPSHOT after release
stoty
commented
Jan 30, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test version snapshot phoenix-thirdparty