Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6360 phoenix-core has compile dependency on phoenix-hbase-compat - #1129
Closed
stoty wants to merge 1 commit into
Closed
PHOENIX-6360 phoenix-core has compile dependency on phoenix-hbase-compat#1129stoty wants to merge 1 commit into
stoty wants to merge 1 commit into
Conversation
stoty
commented
Feb 3, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
| <unpack>false</unpack> | ||
| <outputDirectory>/lib</outputDirectory> | ||
| <includes> | ||
| <include>org.apache.phoenix:phoenix-hbase-compat-${hbase.compat.version}</include> |
Contributor
There was a problem hiding this comment.
This is to include the user specified compat jar in tarball right?
ContributorAuthor
There was a problem hiding this comment.
Exactly.
This may be needed by things like phoenix-pherf or the tracing server.
ContributorAuthor
There was a problem hiding this comment.
Though IIRC pherf already uses phoenix-client, so it may not be.
But we are shipping so much junk in /lib, that one more jar doesn't make a difference.
virajjasani
approved these changes
Feb 3, 2021
| <unpack>false</unpack> | ||
| <outputDirectory>/lib</outputDirectory> | ||
| <includes> | ||
| <include>org.apache.phoenix:phoenix-hbase-compat-${hbase.compat.version}</include> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.