PHOENIX-6395 Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.

[vmeka2020]

Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	15m 59s	master passed
+0	hbaserecompile	23m 14s	HBase recompiled.
+1 💚	compile	1m 5s	master passed
+1 💚	checkstyle	0m 41s	master passed
+1 💚	javadoc	0m 52s	master passed
+0 🆗	spotbugs	3m 5s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 2s	the patch passed
+0	hbaserecompile	17m 55s	HBase recompiled.
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
-1 ❌	checkstyle	0m 42s	phoenix-core: The patch generated 14 new + 319 unchanged - 13 fixed = 333 total (was 332)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 49s	the patch passed
+1 💚	spotbugs	3m 14s	the patch passed
		_ Other Tests _
-1 ❌	unit	101m 35s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 44s	The patch does not generate ASF License warnings.
		155m 46s

Reason	Tests
Failed junit tests	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
	phoenix.end2end.PermissionNSDisabledIT
	phoenix.end2end.PermissionNSEnabledIT
	phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT
	phoenix.end2end.PermissionsCacheIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1151
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname	Linux bd8b24b11d86 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 8668bfa
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/testReport/
Max. process+thread count	8965 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	8m 12s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	31m 0s	master passed
+0	hbaserecompile	38m 25s	HBase recompiled.
+1 💚	compile	1m 8s	master passed
+1 💚	checkstyle	1m 7s	master passed
+1 💚	javadoc	0m 59s	master passed
+0 🆗	spotbugs	3m 43s	phoenix-core in master has 973 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	17m 11s	the patch passed
+0	hbaserecompile	28m 24s	HBase recompiled.
+1 💚	compile	1m 13s	the patch passed
+1 💚	javac	1m 13s	the patch passed
-1 ❌	checkstyle	1m 6s	phoenix-core: The patch generated 16 new + 173 unchanged - 12 fixed = 189 total (was 185)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 54s	the patch passed
+1 💚	spotbugs	3m 37s	the patch passed
		_ Other Tests _
-1 ❌	unit	119m 4s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 32s	The patch does not generate ASF License warnings.
		207m 45s

Reason	Tests
Failed junit tests	phoenix.end2end.PermissionsCacheIT
	phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT
	phoenix.end2end.PermissionNSDisabledIT
	phoenix.end2end.PermissionNSEnabledIT
	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1151
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname	Linux d21160d90aa6 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 025a4af
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/testReport/
Max. process+thread count	5960 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[gjacoby126]

@vmeka2020 - are you still interested in getting this patch into Phoenix 5.2? Looks like this PR needs to be rebased before we can see if the tests are currently passing.

[stoty]

A modified version of this patch has already been merged to master and 5.1