Skip to content

PHOENIX-6370 4.x branch still includes the phoenix-pig example files - #1153

Closed
stoty wants to merge 1 commit into
apache:4.xfrom
stoty:PHOENIX-6370
Closed

PHOENIX-6370 4.x branch still includes the phoenix-pig example files#1153
stoty wants to merge 1 commit into
apache:4.xfrom
stoty:PHOENIX-6370

Conversation

@stoty

Copy link
Copy Markdown
Contributor

No description provided.

@dbwongdbwong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM not sure if github shows but I'm assuming the folder was deleted?

@stoty

Copy link
Copy Markdown
ContributorAuthor

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ 4.x Compile Tests _
_ Patch Compile Tests _
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚shelldocs0m 0sThere were no new shelldocs issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
7m 33s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1153/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1153
Optional Testsdupname asflicense shellcheck shelldocs
unameLinux 6733aa61e07d 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / 14ce2ae
Max. process+thread count43 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1153/1/console
versionsgit=2.7.4 maven=3.3.9 shellcheck=0.7.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@stoty

Copy link
Copy Markdown
ContributorAuthor

Thanks @dbwong and @virajjasani.

git doesn't store empty folders, so effectively yes.

@stotystoty closed this Feb 23, 2021
@stoty
stoty deleted the PHOENIX-6370 branch July 29, 2021 14:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@stoty@virajjasani@dbwong