Phoenix 6376

[stoty]

No description provided.

[yanxinyi]

+1 LGTM! In fact, I do like your approach better :)

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 49s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	16m 0s	master passed
+0	hbaserecompile	23m 6s	HBase recompiled.
+1 💚	compile	1m 6s	master passed
+1 💚	checkstyle	0m 38s	master passed
+1 💚	javadoc	0m 55s	master passed
+0 🆗	spotbugs	3m 21s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	9m 22s	the patch passed
+0	hbaserecompile	19m 47s	HBase recompiled.
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
-1 ❌	checkstyle	0m 38s	phoenix-core: The patch generated 9 new + 341 unchanged - 5 fixed = 350 total (was 346)
-1 ❌	shellcheck	0m 0s	The patch generated 6 new + 6 unchanged - 2 fixed = 12 total (was 8)
+1 💚	shelldocs	0m 3s	There were no new shelldocs issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 53s	the patch passed
+1 💚	spotbugs	3m 18s	the patch passed
		_ Other Tests _
-1 ❌	unit	113m 22s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 34s	The patch does not generate ASF License warnings.
		173m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1163/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1163
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile shellcheck shelldocs
uname	Linux eb8eaf518adf 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 5d78494
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1163/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
shellcheck	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1163/1/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1163/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1163/1/testReport/
Max. process+thread count	14527 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1163/1/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.7.0 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.