Skip to content

PHOENIX-6409 Include local index uncovered columns merge in explain plan. - #1166

Merged
lhofhansl merged 1 commit into
apache:masterfrom
lhofhansl:6409
Mar 14, 2021
Merged

PHOENIX-6409 Include local index uncovered columns merge in explain plan.#1166
lhofhansl merged 1 commit into
apache:masterfrom
lhofhansl:6409

Conversation

@lhofhansl

@lhofhansllhofhansl commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

See Jira for discussion.

@stoty

stoty commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall16m 13smaster passed
+0hbaserecompile23m 39sHBase recompiled.
+1 💚compile1m 2smaster passed
+1 💚checkstyle0m 35smaster passed
+1 💚javadoc0m 51smaster passed
+0 🆗spotbugs3m 4sphoenix-core in master has 959 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 4sthe patch passed
+0hbaserecompile17m 42sHBase recompiled.
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
-1 ❌checkstyle0m 35sphoenix-core: The patch generated 1 new + 115 unchanged - 0 fixed = 116 total (was 115)
+1 💚whitespace0m 1sThe patch has no whitespace issues.
+1 💚javadoc0m 51sthe patch passed
+1 💚spotbugs3m 15sthe patch passed
_ Other Tests _
-1 ❌unit109m 51sphoenix-core in the patch failed.
+1 💚asflicense0m 48sThe patch does not generate ASF License warnings.
169m 4s
ReasonTests
Failed junit testsphoenix.end2end.CostBasedDecisionIT
phoenix.end2end.join.HashJoinLocalIndexIT
phoenix.end2end.index.ViewIndexIT
phoenix.end2end.index.MutableIndexIT
phoenix.end2end.ConcurrentUpsertsWithoutIndexedColsIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1166
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 0791c4691652 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 8e06ada
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/1/testReport/
Max. process+thread count15052 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@lhofhansl

lhofhansl commented Mar 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Fixed failures in other tests due to plan changes.

lhofhansl
lhofhansl commented Mar 12, 2021
View reviewed changes
Comment threadphoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java
}
} while (filterIterator.hasNext());
}
Set<PColumn> dataColumns = context.getDataColumns();

@lhofhansllhofhanslMar 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically if you wanted to be pedantic this would be after SERVER FILTER BY FIRST KEY ONLY and before any other filters. Since Phoenix puts these together in one line I chose to put this in front.

@stoty

stoty commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 14smaster passed
+0hbaserecompile22m 2sHBase recompiled.
+1 💚compile1m 4smaster passed
+1 💚checkstyle0m 35smaster passed
+1 💚javadoc0m 51smaster passed
+0 🆗spotbugs3m 4sphoenix-core in master has 959 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall7m 58sthe patch passed
+0hbaserecompile17m 18sHBase recompiled.
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
-1 ❌checkstyle0m 37sphoenix-core: The patch generated 1 new + 115 unchanged - 0 fixed = 116 total (was 115)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 52sthe patch passed
+1 💚spotbugs3m 15sthe patch passed
_ Other Tests _
-1 ❌unit106m 58sphoenix-core in the patch failed.
+1 💚asflicense0m 42sThe patch does not generate ASF License warnings.
163m 56s
ReasonTests
Failed junit testsphoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1166
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 1fb1f90c49f6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 8e06ada
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/2/testReport/
Max. process+thread count14250 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@lhofhansl
lhofhansl requested review from gjacoby126 and kadirozde and removed request for gjacoby126March 12, 2021 18:35
kadirozde
kadirozde approved these changes Mar 12, 2021
View reviewed changes

@kadirozdekadirozde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, Thanks

@lhofhansl

lhofhansl commented Mar 13, 2021

Copy link
Copy Markdown
ContributorAuthor

Also added to explain plan attributes

@lhofhansl

lhofhansl commented Mar 13, 2021

Copy link
Copy Markdown
ContributorAuthor

@kadirozde Thanks for the review. I also added this to explain plan attributes so that it is available to the explain API. If you could have a quick extra look - it's a minor addition.

@stoty

stoty commented Mar 14, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall16m 58smaster passed
+0hbaserecompile23m 52sHBase recompiled.
+1 💚compile1m 3smaster passed
+1 💚checkstyle0m 41smaster passed
+1 💚javadoc1m 4smaster passed
+0 🆗spotbugs3m 21sphoenix-core in master has 959 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 48sthe patch passed
+0hbaserecompile19m 17sHBase recompiled.
+1 💚compile1m 6sthe patch passed
+1 💚javac1m 6sthe patch passed
-1 ❌checkstyle0m 41sphoenix-core: The patch generated 13 new + 455 unchanged - 2 fixed = 468 total (was 457)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 54sthe patch passed
+1 💚spotbugs3m 23sthe patch passed
_ Other Tests _
-1 ❌unit110m 23sphoenix-core in the patch failed.
+1 💚asflicense0m 44sThe patch does not generate ASF License warnings.
166m 52s
ReasonTests
Failed junit testsphoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1166
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux af87004b417a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 868c8ef
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/3/testReport/
Max. process+thread count14792 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1166/3/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Mar 14, 2021
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@lhofhansl

lhofhansl commented Mar 14, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks @virajjasani . Merging in a few.

@lhofhansl
lhofhansl merged commit e0c500d into apache:masterMar 14, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virajjasanivirajjasanivirajjasani approved these changes
@kadirozdekadirozdekadirozde approved these changes
@gjacoby126gjacoby126Awaiting requested review from gjacoby126

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lhofhansl@stoty@virajjasani@kadirozde