Skip to content

PHOENIX-6419 Unused getResolverForQuery() in QueryCompiler.verifySCN() - #1173

Closed
stoty wants to merge 1 commit into
apache:masterfrom
stoty:PHOENIX-6419
Closed

PHOENIX-6419 Unused getResolverForQuery() in QueryCompiler.verifySCN()#1173
stoty wants to merge 1 commit into
apache:masterfrom
stoty:PHOENIX-6419

Conversation

@stoty

Copy link
Copy Markdown
Contributor

No description provided.

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending QA

@stoty

Copy link
Copy Markdown
ContributorAuthor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 5sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall17m 1smaster passed
+0hbaserecompile24m 8sHBase recompiled.
+1 💚compile1m 4smaster passed
+1 💚checkstyle0m 38smaster passed
+1 💚javadoc0m 54smaster passed
+0 🆗spotbugs3m 20sphoenix-core in master has 959 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall9m 48sthe patch passed
+0hbaserecompile20m 7sHBase recompiled.
+1 💚compile1m 5sthe patch passed
+1 💚javac1m 5sthe patch passed
+1 💚checkstyle0m 39sphoenix-core: The patch generated 0 new + 373 unchanged - 1 fixed = 373 total (was 374)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 51sthe patch passed
+1 💚spotbugs3m 28sphoenix-core generated 0 new + 958 unchanged - 1 fixed = 958 total (was 959)
_ Other Tests _
-1 ❌unit109m 49sphoenix-core in the patch failed.
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
172m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1173
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 6cd67aeb90ef 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 7bfe5d7
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1173/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1173/1/testReport/
Max. process+thread count10001 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1173/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@gjacoby126gjacoby126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@stotystoty closed this Mar 19, 2021
@stoty
stoty deleted the PHOENIX-6419 branch July 29, 2021 14:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@stoty@gjacoby126@virajjasani