Skip to content

PHOENIX-6419 Unused getResolverForQuery() in QueryCompiler.verifySCN() - #1174

Closed
stoty wants to merge 1 commit into
apache:4.xfrom
stoty:PHOENIX-6419-4.x
Closed

PHOENIX-6419 Unused getResolverForQuery() in QueryCompiler.verifySCN()#1174
stoty wants to merge 1 commit into
apache:4.xfrom
stoty:PHOENIX-6419-4.x

Conversation

@stoty

Copy link
Copy Markdown
Contributor

No description provided.

@virajjasanivirajjasani added the backport Backport PR label Mar 19, 2021
@stoty

Copy link
Copy Markdown
ContributorAuthor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 19sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚mvninstall13m 52s4.x passed
+1 💚compile1m 4s4.x passed
+1 💚checkstyle0m 34s4.x passed
+1 💚javadoc0m 50s4.x passed
+0 🆗spotbugs3m 8sphoenix-core in 4.x has 944 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall5m 47sthe patch passed
+1 💚compile1m 2sthe patch passed
+1 💚javac1m 2sthe patch passed
-1 ❌checkstyle0m 33sphoenix-core: The patch generated 2 new + 331 unchanged - 3 fixed = 333 total (was 334)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 46sthe patch passed
+1 💚spotbugs3m 47sphoenix-core generated 0 new + 943 unchanged - 1 fixed = 943 total (was 944)
_ Other Tests _
+1 💚unit138m 30sphoenix-core in the patch passed.
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
176m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1174/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1174
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux 6b5ae5beeaf8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / e6d7d0b
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1174/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1174/1/testReport/
Max. process+thread count5965 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1174/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@gjacoby126gjacoby126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for catching this @stoty

@stotystoty closed this Mar 19, 2021
@stoty
stoty deleted the PHOENIX-6419-4.x branch July 29, 2021 14:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportBackport PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@stoty@gjacoby126@virajjasani