Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2. - #1177
Merged
Conversation
stoty
commented
Mar 22, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
virajjasani
approved these changes
Mar 22, 2021
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
+1, left one minor comment if you would like to include multiple cols
| } else { | ||
| // cannot use EncodedQualifiersColumnProjectionFilter in this case | ||
| // since there's an unknown set of qualifiers (cf.*) | ||
| trackedColumnsBitset = null; |
Contributor
There was a problem hiding this comment.
Yeah I think this makes sense, and hopefully should work for multiple filters too. Shall we add one more test to cover multiple cols and filters? Something likeSELECT w.*, x.* FROM tableName WHERE y.v2='xyz' and z.v3='abc' ?
ContributorAuthor
There was a problem hiding this comment.
Yeah... Lemme add that test and then merge.
Thanks @virajjasani
lhofhansl
commented
Mar 22, 2021
ContributorAuthor
I'll also check the test failure. |
lhofhansl
commented
Mar 22, 2021
ContributorAuthor
Actually... When I add local indexes into the mix it still fails for another reason. I'll look into that as well. If it's an easy fix I'll add it here otherwise I'll file another jira. |
lhofhansl
commented
Mar 22, 2021
ContributorAuthor
Added more tests as @virajjasani suggested. Also added local indexes to the test, and included an additional fix for local indexes. |
lhofhansl
commented
Mar 22, 2021
| * Disabling this optimization for tables with more than one column family. | ||
| * See PHOENIX-3890. | ||
| */ | ||
| return !scan.isRaw() && table.getColumnFamilies().size() <= 1 && table.getImmutableStorageScheme() != null |
ContributorAuthor
There was a problem hiding this comment.
This inadvertently caught local indexes too (which have 0 column families declared in their table definition)
lhofhansl
commented
Mar 22, 2021
ContributorAuthor
Expanded the test slightly to also do a CF.* from a column family with an indexed column. |
stoty
commented
Mar 22, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
lhofhansl
commented
Mar 22, 2021
ContributorAuthor
Last test run still looks good. |
stoty
commented
Mar 22, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
lhofhansl
commented
Mar 23, 2021
ContributorAuthor
Thanks @virajjasani |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Jira. In the SELECT CF1.* WHERE CF2.C ... cannot use the EncodedQualifiersColumnProjectionFilter since the number of qualifiers is not know (so the trackcolumns Bitset cannot be build ahead of time).