PHOENIX-6444 Extend Cell Tags to Delete object for Indexer coproc

[shahrs87]

No description provided.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 57s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	15m 1s	4.x passed
+1 💚	compile	1m 11s	4.x passed
+1 💚	checkstyle	0m 49s	4.x passed
+1 💚	javadoc	0m 52s	4.x passed
+0 🆗	spotbugs	3m 22s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 39s	the patch passed
+1 💚	compile	1m 18s	the patch passed
+1 💚	javac	1m 18s	the patch passed
-1 ❌	checkstyle	0m 56s	phoenix-core: The patch generated 12 new + 1120 unchanged - 14 fixed = 1132 total (was 1134)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 54s	the patch passed
+1 💚	spotbugs	3m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	142m 4s	phoenix-core in the patch passed.
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		182m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1200
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux d2366ea93861 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / b0772eb
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/testReport/
Max. process+thread count	6387 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[shahrs87]

There are few checkstyle warnings for line length.
According to checker.xml file, the line length should be less than 100 but I am getting warning for less than 80 length.

[shahrs87]

@gjacoby126 could you please review this patch ? Thank you !

[gjacoby126]

@shahrs87 - the JIRA and master-branch version of this PR say "PHOENIX-6444 - Extend Cell Tags..." while this one is "PHOENIX-6444 - Add Cell Tags...". I don't have an opinion between the two options, but the commits should have the same title between the JIRA and two branches.

[gjacoby126]

+1 to the change itself, just please see comment about harmonizing the commit names across branches.

[shahrs87]

+1 to the change itself, just please see comment about harmonizing the commit names across branches.

@gjacoby126 Done. Changed the commit message here to be same as master branch.

[shahrs87]

Thank you @gjacoby126 for the review and commit,

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	13m 58s	4.x passed
+1 💚	compile	1m 0s	4.x passed
+1 💚	checkstyle	0m 54s	4.x passed
+1 💚	javadoc	0m 47s	4.x passed
+0 🆗	spotbugs	2m 59s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 47s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
-1 ❌	checkstyle	0m 55s	phoenix-core: The patch generated 12 new + 1120 unchanged - 14 fixed = 1132 total (was 1134)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 45s	the patch passed
+1 💚	spotbugs	3m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	136m 36s	phoenix-core in the patch passed.
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		169m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1200
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 8acd1d1b2422 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / b0772eb
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/2/testReport/
Max. process+thread count	5938 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1200/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.