Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6447: Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter - #1201
Merged
Merged
Conversation
sandeepvinayak
commented
Apr 21, 2021
ContributorAuthor
@gjacoby126@yanxinyi can you please review this to add system child link table in systemcatalog wal entry filter for replication. |
sandeepvinayakforce-pushed
the
PHOENIX-6447-4.16
branch
from
April 21, 2021 00:36
26d6c90 to
04c7626Comparestoty
commented
Apr 21, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
sandeepvinayakforce-pushed
the
PHOENIX-6447-4.16
branch
2 times, most recently
from
April 21, 2021 18:06
2ecde33 to
fc9792fCompareUh oh!
There was an error while loading. Please reload this page.
| private boolean isTenantRowCellSystemChildLink(final Cell cell) { | ||
| ImmutableBytesWritable key = new ImmutableBytesWritable( | ||
| cell.getRowArray(), cell.getRowOffset(), cell.getRowLength()); | ||
| //rows in system.catalog that aren't tenant-owned will |
Contributor
There was a problem hiding this comment.
nit: Remove system.catalog from comments.
| cell.getRowArray(), cell.getRowOffset(), cell.getRowLength()); | ||
| //rows in system.catalog that aren't tenant-owned will | ||
| // have a leading separator byte | ||
| boolean isTenantRowCell = |
Contributor
There was a problem hiding this comment.
Does the schema for system.child_link table the same as that for system.catalog? and does this assumption of leading separator byte holds true there as well? If so we can refactor isTenantRowCellSystemCatalog and reuse the same function here.
ContributorAuthor
There was a problem hiding this comment.
The schema remains the same but the system catalog table is not supposed to have tenant-owned data with empty tenant id anymore. Thus, I believe we need different methods.
sandeepvinayakforce-pushed
the
PHOENIX-6447-4.16
branch
from
April 21, 2021 22:29
5f5457a to
ccb7d4dComparegjacoby126
requested changes
Apr 21, 2021
gjacoby126
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a couple nits
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
stoty
commented
Apr 22, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
gjacoby126
commented
Apr 22, 2021
Contributor
@sandeepvinayak - could you please change your commit message to match the JIRA name (with the JIRA number). Then this looks good to go. |
sandeepvinayakforce-pushed
the
PHOENIX-6447-4.16
branch
from
April 22, 2021 17:34
c81bc6f to
67bb8ffComparesandeepvinayak
commented
Apr 22, 2021
ContributorAuthor
@gjacoby126 changed the commit message |
gjacoby126
approved these changes
Apr 22, 2021
gjacoby126
left a comment
Contributor
There was a problem hiding this comment.
+1, thanks for the patch @sandeepvinayak
gjacoby126 pushed a commit
that referenced
this pull request
Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.