Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6432 Add support for additional load generators - #1211
Merged
Conversation
jpisaac
commented
Apr 26, 2021
ContributorAuthor
stoty
commented
Apr 26, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
yanxinyi
reviewed
May 4, 2021
| import org.apache.phoenix.pherf.rules.RulesApplier; | ||
| import org.apache.phoenix.thirdparty.com.google.common.collect.Sets; | ||
| import org.apache.phoenix.pherf.configuration.*; |
Contributor
There was a problem hiding this comment.
nit: can you fix the import * here
yanxinyi
reviewed
May 4, 2021
| // This holds the info whether the tenant view was created (initialized) or not. | ||
| return BloomFilter.create(tenantViewFunnel, numTenants, 0.01); | ||
| return BloomFilter.create(tenantViewFunnel, numTenants, 0.0000001); |
Contributor
There was a problem hiding this comment.
why did we change from 0.01 to 0.0000001?
ContributorAuthor
There was a problem hiding this comment.
https://hur.st/bloomfilter/?n=1000000&p=1.0E-7&m=&k=
This shows that the space requirements are not that large for 1M items, for a false-positive probability of 1 in 10
million
yanxinyi
reviewed
May 4, 2021
| @@ -0,0 +1,52 @@ | |||
| package org.apache.phoenix.pherf.workload.mt.generators; | |||
yanxinyi
reviewed
May 4, 2021
| @@ -0,0 +1,169 @@ | |||
| package org.apache.phoenix.pherf.workload.mt.generators; | |||
yanxinyi
reviewed
May 4, 2021
| @@ -0,0 +1,25 @@ | |||
| package org.apache.phoenix.pherf.workload.mt.generators; | |||
yanxinyi
reviewed
May 4, 2021
| @@ -0,0 +1,194 @@ | |||
| package org.apache.phoenix.pherf.workload.mt.generators; | |||
yanxinyi
reviewed
May 4, 2021
| @@ -0,0 +1,169 @@ | |||
| package org.apache.phoenix.pherf.workload.mt.generators; | |||
| import com.beust.jcommander.internal.Maps; | |||
Contributor
There was a problem hiding this comment.
what's the benefit of not using com.google.common.collect.Maps?
yanxinyi
reviewed
May 5, 2021
| package org.apache.phoenix.pherf.workload.mt; | ||
| import com.google.common.collect.Lists; | ||
| import com.lmax.disruptor.WorkHandler; |
Contributor
There was a problem hiding this comment.
why do we need this WorkHandler?
Contributor
There was a problem hiding this comment.
yes. I didn't see the usage in this class
stoty
commented
May 6, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
May 6, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
May 6, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
yanxinyi
approved these changes
May 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.