Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6271: Effective DDL generated by SchemaExtractionTool should … - #1212
Merged
Conversation
stoty
commented
Apr 27, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
gokceni
reviewed
Apr 27, 2021
| } | ||
| if(tableNameNeedsQuotes || schemaNameNeedsQuotes) { | ||
| pTableFullName = pSchemaName + "." + pTableName; | ||
| if (pSchemaName != null && !pSchemaName.isEmpty()) { |
Contributor
There was a problem hiding this comment.
Also do you need to think about namespaceenabled? I am guessing no
| private static boolean isQuotesNeeded(String name) { | ||
| // first char numeric or non-underscore | ||
| if(!Character.isAlphabetic(name.charAt(0)) && name.charAt(0)!='_') { | ||
| if (name == null || name.isEmpty()) { |
gjacoby126
requested changes
Apr 27, 2021
gjacoby126
left a comment
Contributor
There was a problem hiding this comment.
Maybe I'm misunderstanding what you're trying to do in this patch, but the results for indexes look incorrect to me. The effective DDL of an index shouldn't contain the PK suffix inherited from the base table or parent view. (I can see it being useful to include such a thing in a SQL comment or something, but not the CREATE INDEX statement itself)
| if (effectivePK.isEmpty()) { | ||
| effectivePK = indexPkSet; | ||
| // This is added because of PHOENIX-2340 | ||
| if (dataPTable.isMultiTenant() && indexPKName.contains(dataPKName.get(0))) { |
Contributor
There was a problem hiding this comment.
nit: can we have a String tenantId = dataPKName.get(0); line and use that in the checks? I worry that if we ever implement PHOENIX-5248 that the current logic here will be too subtle for the implementer to realize that it needs to be changed if we can't depend on first column == tenantId.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…maintain the order of PK and other columns
stoty
commented
Apr 29, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
gjacoby126
approved these changes
Apr 29, 2021
gjacoby126
left a comment
Contributor
There was a problem hiding this comment.
+1, thanks for the patch and adding the extra test assertions, @swaroopak
| import javax.annotation.Nullable; | ||
| import com.google.common.base.Strings; |
Contributor
There was a problem hiding this comment.
Remember that you'll have to use the shaded version when you port to master.
Uh oh!
There was an error while loading. Please reload this page.
gokceni
approved these changes
Apr 29, 2021
swaroopak
commented
Apr 29, 2021
ContributorAuthor
Thank you for the review @gjacoby126@gokceni |
swaroopak added a commit
that referenced
this pull request
May 21, 2021
…maintain the order of PK and other columns (#1212) Co-authored-by: Swaroopa Kadam <s.kadam@apache.org>
stoty pushed a commit
to stoty/phoenix
that referenced
this pull request
Jun 18, 2021
…maintain the order of PK and other columns (apache#1212) Co-authored-by: Swaroopa Kadam <s.kadam@apache.org>
asfgit pushed a commit
that referenced
this pull request
Jun 18, 2021
…maintain the order of PK and other columns (#1212) Co-authored-by: Swaroopa Kadam <s.kadam@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…maintain the order of PK and other columns