PHOENIX-6456 Support query logging for DDL and DML

[richardantal]

Change-Id: I926843cfb9074d2e8641e0d6005a62ac631de7ce

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	8m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	15m 4s	4.x passed
+1 💚	compile	1m 7s	4.x passed
+1 💚	checkstyle	1m 20s	4.x passed
+1 💚	javadoc	0m 49s	4.x passed
+0 🆗	spotbugs	3m 23s	phoenix-core in 4.x has 946 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 17s	the patch passed
+1 💚	compile	1m 16s	the patch passed
+1 💚	javac	1m 16s	the patch passed
-1 ❌	checkstyle	1m 25s	phoenix-core: The patch generated 85 new + 3461 unchanged - 47 fixed = 3546 total (was 3508)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	1m 1s	the patch passed
+1 💚	spotbugs	4m 26s	phoenix-core generated 0 new + 945 unchanged - 1 fixed = 945 total (was 946)
		_ Other Tests _
+1 💚	unit	212m 25s	phoenix-core in the patch passed.
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		259m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1213/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1213
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 73c4735c85d2 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / c3f166e
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1213/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1213/1/testReport/
Max. process+thread count	5078 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1213/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

+1 LGTM

[dbwong]

Hi can we get some unit tests and integration tests for this? Our team is plannign some logging improvements in the near future and we want to have the right set of regression tests so that logging that was there does not get dropped.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	15m 43s	4.x passed
+1 💚	compile	1m 17s	4.x passed
+1 💚	checkstyle	1m 25s	4.x passed
+1 💚	javadoc	0m 50s	4.x passed
+0 🆗	spotbugs	3m 20s	phoenix-core in 4.x has 946 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 47s	the patch passed
+1 💚	compile	1m 12s	the patch passed
+1 💚	javac	1m 12s	the patch passed
-1 ❌	checkstyle	1m 32s	phoenix-core: The patch generated 124 new + 3456 unchanged - 52 fixed = 3580 total (was 3508)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	javadoc	0m 58s	phoenix-core generated 1 new + 91 unchanged - 1 fixed = 92 total (was 92)
+1 💚	spotbugs	4m 5s	phoenix-core generated 0 new + 945 unchanged - 1 fixed = 945 total (was 946)
		_ Other Tests _
+1 💚	unit	205m 8s	phoenix-core in the patch passed.
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		244m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1213
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 68cf6338bb1b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / c3f166e
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
javadoc	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1213/2/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1213/2/testReport/
Max. process+thread count	5224 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1213/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.