Skip to content

PHOENIX-6271: Effective DDL generated by SchemaExtractionTool should … - #1218

Merged
swaroopak merged 1 commit into
apache:masterfrom
swaroopak:PHOENIX-6271_master
May 4, 2021
Merged

PHOENIX-6271: Effective DDL generated by SchemaExtractionTool should …#1218
swaroopak merged 1 commit into
apache:masterfrom
swaroopak:PHOENIX-6271_master

Conversation

@swaroopak

@swaroopakswaroopak commented May 3, 2021

Copy link
Copy Markdown
Contributor

…maintain the order of PK and other columns

@stoty

stoty commented May 4, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep4m 54sMaven dependency ordering for branch
+1 💚mvninstall12m 41smaster passed
+0hbaserecompile24m 40sHBase recompiled.
+1 💚compile1m 45smaster passed
+1 💚checkstyle0m 58smaster passed
+1 💚javadoc1m 9smaster passed
+0 🆗spotbugs3m 19sphoenix-core in master has 959 extant spotbugs warnings.
+0 🆗spotbugs0m 42sphoenix-tools in master has 3 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
-1 ❌mvninstall9m 58sroot in the patch failed.
+0hbaserecompile17m 4sHBase recompiled.
+1 💚compile1m 32sthe patch passed
+1 💚javac1m 32sthe patch passed
-1 ❌checkstyle0m 43sphoenix-core: The patch generated 2 new + 709 unchanged - 3 fixed = 711 total (was 712)
-1 ❌checkstyle0m 16sphoenix-tools: The patch generated 34 new + 191 unchanged - 27 fixed = 225 total (was 218)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 10sthe patch passed
+1 💚spotbugs4m 25sthe patch passed
_ Other Tests _
+1 💚unit230m 51sphoenix-core in the patch passed.
-1 ❌unit2m 59sphoenix-tools in the patch failed.
+1 💚asflicense0m 25sThe patch does not generate ASF License warnings.
294m 46s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1218
JIRA IssuePHOENIX-6271
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 777534dd1cfd 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 55aeb15
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstallhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/testReport/
Max. process+thread count11400 (vs. ulimit of 30000)
modulesC: phoenix-core phoenix-tools U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@swaroopak
swaroopakforce-pushed the PHOENIX-6271_master branch from aca2bab to 576da65CompareMay 4, 2021 16:34
@stoty

stoty commented May 4, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep5m 24sMaven dependency ordering for branch
+1 💚mvninstall13m 6smaster passed
+0hbaserecompile26m 27sHBase recompiled.
+1 💚compile1m 36smaster passed
+1 💚checkstyle0m 59smaster passed
+1 💚javadoc1m 9smaster passed
+0 🆗spotbugs3m 16sphoenix-core in master has 959 extant spotbugs warnings.
+0 🆗spotbugs0m 42sphoenix-tools in master has 3 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall9m 55sthe patch passed
+0hbaserecompile17m 2sHBase recompiled.
+1 💚compile1m 34sthe patch passed
+1 💚javac1m 34sthe patch passed
-1 ❌checkstyle0m 43sphoenix-core: The patch generated 9 new + 702 unchanged - 10 fixed = 711 total (was 712)
-1 ❌checkstyle0m 16sphoenix-tools: The patch generated 34 new + 191 unchanged - 27 fixed = 225 total (was 218)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc1m 10sthe patch passed
+1 💚spotbugs4m 22sthe patch passed
_ Other Tests _
-1 ❌unit114m 22sphoenix-core in the patch failed.
+1 💚unit3m 31sphoenix-tools in the patch passed.
+1 💚asflicense1m 15sThe patch does not generate ASF License warnings.
183m 21s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1218
JIRA IssuePHOENIX-6271
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml
unameLinux f10ebe8ad762 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 55aeb15
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/testReport/
Max. process+thread count10805 (vs. ulimit of 30000)
modulesC: phoenix-core phoenix-tools U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@swaroopak
swaroopak merged commit e3a1e77 into apache:masterMay 4, 2021
stoty pushed a commit to stoty/phoenix that referenced this pull request Jun 18, 2021
@swaroopak@stoty
PHOENIX-6271: Effective DDL generated by SchemaExtractionTool should …
0dfb8db
…maintain the order of PK and other columns (apache#1218)
@stotystoty mentioned this pull request Jun 18, 2021
Closed
asfgit pushed a commit that referenced this pull request Jun 18, 2021
@swaroopak@stoty
PHOENIX-6271: Effective DDL generated by SchemaExtractionTool should …
8b99826
…maintain the order of PK and other columns (#1218)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swaroopak@stoty