Skip to content

PHOENIX-6437: Parent-Child Delete marker should get replicated via Sy… - #1222

Merged
gjacoby126 merged 1 commit into
apache:masterfrom
ankitjain64:PHOENIX-6437-master
May 5, 2021
Merged

PHOENIX-6437: Parent-Child Delete marker should get replicated via Sy…#1222
gjacoby126 merged 1 commit into
apache:masterfrom
ankitjain64:PHOENIX-6437-master

Conversation

@ankitjain64

Copy link
Copy Markdown
Contributor

…stemCatalogWalEntryFilter

@ankitjain64

Copy link
Copy Markdown
ContributorAuthor

@gjacoby126 This is the master branch PR for this. Please have a look when you get a chance. Thanks

@stoty

stoty commented May 5, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 52smaster passed
+0hbaserecompile22m 36sHBase recompiled.
+1 💚compile1m 6smaster passed
+1 💚checkstyle0m 32smaster passed
+1 💚javadoc0m 51smaster passed
+0 🆗spotbugs3m 18sphoenix-core in master has 959 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 44sthe patch passed
+0hbaserecompile18m 51sHBase recompiled.
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
-1 ❌checkstyle0m 35sphoenix-core: The patch generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 52sthe patch passed
+1 💚spotbugs3m 21sthe patch passed
_ Other Tests _
+1 💚unit113m 36sphoenix-core in the patch passed.
+1 💚asflicense0m 18sThe patch does not generate ASF License warnings.
169m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1222/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1222
JIRA IssuePHOENIX-6437
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux ff156d3ea027 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / e3a1e77
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1222/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1222/1/testReport/
Max. process+thread count14887 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1222/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@gjacoby126gjacoby126 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @ankitjain64

@gjacoby126
gjacoby126 merged commit 5265164 into apache:masterMay 5, 2021
asfgit pushed a commit that referenced this pull request May 26, 2021
…stemCatalogWalEntryFilter (#1222)
Co-authored-by: Ankit Jain <jainankit@salesforce.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ankitjain64@stoty@gjacoby126