PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries by vmeka2020 · Pull Request #1223 · apache/phoenix

vmeka2020 · 2021-05-06T06:05:13Z

PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries

vmeka2020 · 2021-05-06T06:23:34Z

stoty · 2021-05-06T09:05:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 18s	4.x passed
+1 💚	compile	1m 0s	4.x passed
+1 💚	checkstyle	3m 3s	4.x passed
+1 💚	javadoc	0m 45s	4.x passed
+0 🆗	spotbugs	3m 1s	phoenix-core in 4.x has 945 extant spotbugs warnings.
-0 ⚠️	patch	3m 9s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 47s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
-1 ❌	checkstyle	3m 24s	phoenix-core: The patch generated 709 new + 6124 unchanged - 86 fixed = 6833 total (was 6210)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 45s	the patch passed
-1 ❌	spotbugs	3m 15s	phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945)
		_ Other Tests _
-1 ❌	unit	135m 5s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 51s	The patch does not generate ASF License warnings.
		179m 39s

Reason	Tests
FindBugs	module:phoenix-core
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]
Failed junit tests	phoenix.monitoring.PhoenixTableLevelMetricsIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1223
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux e1333fd65f78 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `aacab94`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/testReport/
Max. process+thread count	5911 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

yanxinyi · 2021-05-06T16:26:14Z

@vmeka2020 the test failures seem related to your code

stoty · 2021-05-06T20:00:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 15s	4.x passed
+1 💚	compile	0m 59s	4.x passed
+1 💚	checkstyle	3m 2s	4.x passed
+1 💚	javadoc	0m 46s	4.x passed
+0 🆗	spotbugs	3m 3s	phoenix-core in 4.x has 945 extant spotbugs warnings.
-0 ⚠️	patch	3m 11s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 39s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
-1 ❌	checkstyle	3m 20s	phoenix-core: The patch generated 754 new + 6081 unchanged - 131 fixed = 6835 total (was 6212)
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	javadoc	0m 46s	the patch passed
-1 ❌	spotbugs	3m 14s	phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945)
		_ Other Tests _
-1 ❌	unit	150m 44s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 48s	The patch does not generate ASF License warnings.
		191m 27s

Reason	Tests
FindBugs	module:phoenix-core
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]
Failed junit tests	phoenix.monitoring.PhoenixTableLevelMetricsIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1223
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 4f65c5f4b276 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `aacab94`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/testReport/
Max. process+thread count	5857 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-07T01:48:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	13m 56s	4.x passed
+1 💚	compile	1m 2s	4.x passed
+1 💚	checkstyle	3m 4s	4.x passed
+1 💚	javadoc	0m 46s	4.x passed
+0 🆗	spotbugs	3m 7s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 46s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
-1 ❌	checkstyle	3m 22s	phoenix-core: The patch generated 710 new + 6125 unchanged - 87 fixed = 6835 total (was 6212)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 45s	the patch passed
-1 ❌	spotbugs	3m 16s	phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945)
		_ Other Tests _
-1 ❌	unit	208m 41s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 51s	The patch does not generate ASF License warnings.
		249m 10s

Reason	Tests
FindBugs	module:phoenix-core
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]
Failed junit tests	phoenix.end2end.AuditLoggingIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1223
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 0547d3569752 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `ddc3996`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/testReport/
Max. process+thread count	5609 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-07T22:18:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	13m 53s	4.x passed
+1 💚	compile	1m 0s	4.x passed
+1 💚	checkstyle	3m 2s	4.x passed
+1 💚	javadoc	0m 46s	4.x passed
+0 🆗	spotbugs	3m 1s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 44s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
-1 ❌	checkstyle	3m 22s	phoenix-core: The patch generated 753 new + 6080 unchanged - 130 fixed = 6833 total (was 6210)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 46s	the patch passed
-1 ❌	spotbugs	3m 13s	phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945)
		_ Other Tests _
-1 ❌	unit	135m 55s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		176m 12s

Reason	Tests
FindBugs	module:phoenix-core
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]
Failed junit tests	phoenix.end2end.AuditLoggingIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1223
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux e89801442dbf 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `ddc3996`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/testReport/
Max. process+thread count	5753 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-08T07:24:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	13m 57s	4.x passed
+1 💚	compile	1m 3s	4.x passed
+1 💚	checkstyle	3m 2s	4.x passed
+1 💚	javadoc	0m 47s	4.x passed
+0 🆗	spotbugs	3m 7s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 41s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
-1 ❌	checkstyle	3m 22s	phoenix-core: The patch generated 709 new + 6124 unchanged - 86 fixed = 6833 total (was 6210)
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	javadoc	0m 46s	the patch passed
-1 ❌	spotbugs	3m 17s	phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945)
		_ Other Tests _
+1 💚	unit	140m 41s	phoenix-core in the patch passed.
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		178m 35s

Reason	Tests
FindBugs	module:phoenix-core
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1223
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 994a97116f92 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `6d6bf9a`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/testReport/
Max. process+thread count	5648 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…unctions for select. upsert and Delete Queries

…ableMetrics Manager class

stoty · 2021-05-10T21:49:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	15m 14s	4.x passed
+1 💚	compile	1m 5s	4.x passed
+1 💚	checkstyle	2m 7s	4.x passed
+1 💚	javadoc	0m 48s	4.x passed
+0 🆗	spotbugs	3m 17s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 47s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
-1 ❌	checkstyle	2m 18s	phoenix-core: The patch generated 709 new + 6124 unchanged - 86 fixed = 6833 total (was 6210)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 46s	the patch passed
-1 ❌	spotbugs	3m 31s	phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945)
		_ Other Tests _
-1 ❌	unit	204m 55s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 41s	The patch does not generate ASF License warnings.
		246m 43s

Reason	Tests
FindBugs	module:phoenix-core
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]
Failed junit tests	phoenix.end2end.AuditLoggingIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1223
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 7ce4bc6e5401 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `6ac64c4`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/testReport/
Max. process+thread count	4799 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-11T05:20:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	15m 34s	4.x passed
+1 💚	compile	1m 5s	4.x passed
+1 💚	checkstyle	2m 7s	4.x passed
+1 💚	javadoc	0m 49s	4.x passed
+0 🆗	spotbugs	3m 17s	phoenix-core in 4.x has 945 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 53s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
-1 ❌	checkstyle	2m 19s	phoenix-core: The patch generated 709 new + 6124 unchanged - 86 fixed = 6833 total (was 6210)
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	javadoc	0m 48s	the patch passed
-1 ❌	spotbugs	3m 35s	phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945)
		_ Other Tests _
-1 ❌	unit	199m 15s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 40s	The patch does not generate ASF License warnings.
		241m 24s

Reason	Tests
FindBugs	module:phoenix-core
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]
Failed junit tests	phoenix.end2end.AuditLoggingIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1223
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux a463bf6aa2bf 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `6ac64c4`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/testReport/
Max. process+thread count	5185 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-13T08:20:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	14m 12s	4.x passed
+1 💚	compile	1m 0s	4.x passed
+1 💚	checkstyle	3m 2s	4.x passed
+1 💚	javadoc	0m 49s	4.x passed
+0 🆗	spotbugs	3m 5s	phoenix-core in 4.x has 946 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 39s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
-1 ❌	checkstyle	3m 22s	phoenix-core: The patch generated 710 new + 6125 unchanged - 87 fixed = 6835 total (was 6212)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 41s	the patch passed
-1 ❌	spotbugs	3m 16s	phoenix-core generated 5 new + 946 unchanged - 0 fixed = 951 total (was 946)
		_ Other Tests _
+1 💚	unit	203m 5s	phoenix-core in the patch passed.
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		241m 5s

Reason	Tests
FindBugs	module:phoenix-core
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1223
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux aef3e5dd294e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `5159f6e`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/testReport/
Max. process+thread count	5315 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

vmeka2020 added 10 commits May 10, 2021 10:41

PHOENIX-6397Implement TableMetricsManager class and its associated f…
90b42a1
…unctions for select. upsert and Delete Queries

adding unit tests, IT tests and hooks for reads/writes/deletes from T…
3d5c95b
…ableMetrics Manager class

addressing Review comments
d9a622a

adding unit tests for TableMetricsManager class
02f72ee

Addressing Review comments
c1327a9

Addressing Review comments
5c9a7cf

fixing unit testcase
67c5248

Adding class Level comments
9a69ccc

Addressing review comments
f9feb0f

Adding NeedsOwnMiniClusterTest tag for IT tests
f3ae442

yanxinyi approved these changes May 10, 2021
View reviewed changes

removing un-used imports
cf5dd79

yanxinyi reviewed May 12, 2021
View reviewed changes

Comment threadphoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixTableLevelMetricsIT.java Outdated

yanxinyi reviewed May 12, 2021
View reviewed changes

Comment threadphoenix-core/src/test/java/org/apache/phoenix/monitoring/TableClientMetricsTest.java

Addressing review commets
f7bacc8

yanxinyi merged commit 67f1f1c into apache:4.xMay 13, 2021

Navigation Menu

Uh oh!

PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries - #1223

PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries#1223
yanxinyi merged 12 commits into
apache:4.xfrom
vmeka2020:4xTableMetrics

vmeka2020 commented May 6, 2021

Uh oh!

vmeka2020 commented May 6, 2021

Uh oh!

stoty commented May 6, 2021

Uh oh!

yanxinyi commented May 6, 2021

Uh oh!

stoty commented May 6, 2021

Uh oh!

stoty commented May 7, 2021

Uh oh!

stoty commented May 7, 2021

Uh oh!

stoty commented May 8, 2021

Uh oh!

stoty commented May 10, 2021

Uh oh!

stoty commented May 11, 2021

Uh oh!

Uh oh!

Uh oh!

stoty commented May 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

vmeka2020 commented May 6, 2021

Uh oh!

vmeka2020 commented May 6, 2021

Uh oh!

stoty commented May 6, 2021

Uh oh!

yanxinyi commented May 6, 2021

Uh oh!

stoty commented May 6, 2021

Uh oh!

stoty commented May 7, 2021

Uh oh!

stoty commented May 7, 2021

Uh oh!

stoty commented May 8, 2021

Uh oh!

stoty commented May 10, 2021

Uh oh!

stoty commented May 11, 2021

Uh oh!

Uh oh!

Uh oh!

stoty commented May 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants