PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries by vmeka2020 · Pull Request #1224 · apache/phoenix

vmeka2020 · 2021-05-06T06:15:17Z

PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries

vmeka2020 · 2021-05-06T06:23:40Z

stoty · 2021-05-06T09:10:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 18s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	16m 14s	master passed
+0	hbaserecompile	23m 5s	HBase recompiled.
+1 💚	compile	1m 4s	master passed
+1 💚	checkstyle	3m 6s	master passed
+1 💚	javadoc	0m 53s	master passed
+0 🆗	spotbugs	3m 5s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 6s	the patch passed
+0	hbaserecompile	17m 45s	HBase recompiled.
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
-1 ❌	checkstyle	3m 27s	phoenix-core: The patch generated 690 new + 6087 unchanged - 74 fixed = 6777 total (was 6161)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 50s	the patch passed
-1 ❌	spotbugs	3m 18s	phoenix-core generated 6 new + 959 unchanged - 0 fixed = 965 total (was 959)
		_ Other Tests _
-1 ❌	unit	111m 38s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 45s	The patch does not generate ASF License warnings.
		174m 34s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.NoOpTableMetricsManager.noOpsTableMetricManager isn't final but should be At NoOpTableMetricsManager.java:be At NoOpTableMetricsManager.java:[line 25]
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 87]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 56]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 68]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 60]
Failed junit tests	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1224
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname	Linux 8bc81b8daec8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `5265164`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/1/testReport/
Max. process+thread count	14526 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-06T19:19:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	15m 41s	master passed
+0	hbaserecompile	22m 31s	HBase recompiled.
+1 💚	compile	1m 1s	master passed
+1 💚	checkstyle	3m 6s	master passed
+1 💚	javadoc	0m 52s	master passed
+0 🆗	spotbugs	3m 7s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 13s	the patch passed
+0	hbaserecompile	18m 14s	HBase recompiled.
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
-1 ❌	checkstyle	3m 29s	phoenix-core: The patch generated 723 new + 6054 unchanged - 107 fixed = 6777 total (was 6161)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 49s	the patch passed
-1 ❌	spotbugs	3m 12s	phoenix-core generated 6 new + 959 unchanged - 0 fixed = 965 total (was 959)
		_ Other Tests _
-1 ❌	unit	113m 6s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 46s	The patch does not generate ASF License warnings.
		171m 58s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.NoOpTableMetricsManager.noOpsTableMetricManager isn't final but should be At NoOpTableMetricsManager.java:be At NoOpTableMetricsManager.java:[line 25]
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 87]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 56]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 68]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 60]
Failed junit tests	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
	phoenix.end2end.AuditLoggingIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1224
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname	Linux 6e26c388b449 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `5265164`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/2/testReport/
Max. process+thread count	13827 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-07T22:17:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	16m 31s	master passed
+0	hbaserecompile	24m 11s	HBase recompiled.
+1 💚	compile	1m 8s	master passed
+1 💚	checkstyle	2m 44s	master passed
+1 💚	javadoc	0m 55s	master passed
+0 🆗	spotbugs	3m 27s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	9m 45s	the patch passed
+0	hbaserecompile	20m 15s	HBase recompiled.
+1 💚	compile	1m 11s	the patch passed
+1 💚	javac	1m 11s	the patch passed
-1 ❌	checkstyle	3m 7s	phoenix-core: The patch generated 690 new + 6087 unchanged - 74 fixed = 6777 total (was 6161)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 55s	the patch passed
-1 ❌	spotbugs	3m 34s	phoenix-core generated 6 new + 959 unchanged - 0 fixed = 965 total (was 959)
		_ Other Tests _
-1 ❌	unit	112m 16s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 46s	The patch does not generate ASF License warnings.
		175m 1s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.NoOpTableMetricsManager.noOpsTableMetricManager isn't final but should be At NoOpTableMetricsManager.java:be At NoOpTableMetricsManager.java:[line 25]
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 87]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 56]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 68]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 60]
Failed junit tests	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1224
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname	Linux 3134b10f3b05 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `5265164`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/3/testReport/
Max. process+thread count	15887 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/3/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-08T07:21:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	16m 44s	master passed
+0	hbaserecompile	23m 34s	HBase recompiled.
+1 💚	compile	1m 3s	master passed
+1 💚	checkstyle	3m 7s	master passed
+1 💚	javadoc	0m 51s	master passed
+0 🆗	spotbugs	3m 7s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 15s	the patch passed
+0	hbaserecompile	18m 15s	HBase recompiled.
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
-1 ❌	checkstyle	3m 27s	phoenix-core: The patch generated 690 new + 6087 unchanged - 74 fixed = 6777 total (was 6161)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 50s	the patch passed
-1 ❌	spotbugs	3m 19s	phoenix-core generated 6 new + 959 unchanged - 0 fixed = 965 total (was 959)
		_ Other Tests _
-1 ❌	unit	113m 28s	phoenix-core in the patch failed.
+1 💚	asflicense	1m 15s	The patch does not generate ASF License warnings.
		175m 42s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.NoOpTableMetricsManager.noOpsTableMetricManager isn't final but should be At NoOpTableMetricsManager.java:be At NoOpTableMetricsManager.java:[line 25]
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 87]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 56]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 68]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 60]
Failed junit tests	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1224
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname	Linux 0aeb069af3e5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `3dcf95d`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/4/testReport/
Max. process+thread count	14769 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/4/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-10T04:14:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 4s	#1224 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#1224
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/5/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

yanxinyi · 2021-05-10T17:43:49Z

@vmeka2020 can you please rebase one more time, thanks!

…unctions for select. upsert and Delete Queries

stoty · 2021-05-10T20:41:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	16m 29s	master passed
+0	hbaserecompile	22m 54s	HBase recompiled.
+1 💚	compile	1m 6s	master passed
+1 💚	checkstyle	3m 2s	master passed
+1 💚	javadoc	0m 50s	master passed
+0 🆗	spotbugs	3m 4s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 13s	the patch passed
+0	hbaserecompile	18m 6s	HBase recompiled.
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
-1 ❌	checkstyle	3m 26s	phoenix-core: The patch generated 690 new + 6087 unchanged - 74 fixed = 6777 total (was 6161)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 51s	the patch passed
-1 ❌	spotbugs	3m 23s	phoenix-core generated 6 new + 959 unchanged - 0 fixed = 965 total (was 959)
		_ Other Tests _
-1 ❌	unit	114m 6s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		173m 30s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.NoOpTableMetricsManager.noOpsTableMetricManager isn't final but should be At NoOpTableMetricsManager.java:be At NoOpTableMetricsManager.java:[line 25]
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 87]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 56]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 68]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 60]
Failed junit tests	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
	phoenix.end2end.AuditLoggingIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1224
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname	Linux a7b49767605b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `88a0128`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/6/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/6/testReport/
Max. process+thread count	15417 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/6/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-11T02:04:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	15m 49s	master passed
+0	hbaserecompile	22m 34s	HBase recompiled.
+1 💚	compile	1m 5s	master passed
+1 💚	checkstyle	3m 4s	master passed
+1 💚	javadoc	0m 52s	master passed
+0 🆗	spotbugs	3m 8s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 10s	the patch passed
+0	hbaserecompile	18m 11s	HBase recompiled.
+1 💚	compile	1m 12s	the patch passed
+1 💚	javac	1m 12s	the patch passed
-1 ❌	checkstyle	3m 26s	phoenix-core: The patch generated 690 new + 6087 unchanged - 74 fixed = 6777 total (was 6161)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 49s	the patch passed
-1 ❌	spotbugs	3m 14s	phoenix-core generated 6 new + 959 unchanged - 0 fixed = 965 total (was 959)
		_ Other Tests _
-1 ❌	unit	111m 51s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		170m 55s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.NoOpTableMetricsManager.noOpsTableMetricManager isn't final but should be At NoOpTableMetricsManager.java:be At NoOpTableMetricsManager.java:[line 25]
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 87]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 56]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 68]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 60]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1224
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname	Linux b61178f59d99 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `6c22b43`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/7/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/7/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/7/testReport/
Max. process+thread count	15443 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/7/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-11T04:57:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	16m 8s	master passed
+0	hbaserecompile	22m 30s	HBase recompiled.
+1 💚	compile	1m 4s	master passed
+1 💚	checkstyle	3m 6s	master passed
+1 💚	javadoc	0m 51s	master passed
+0 🆗	spotbugs	3m 7s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 13s	the patch passed
+0	hbaserecompile	18m 2s	HBase recompiled.
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
-1 ❌	checkstyle	3m 27s	phoenix-core: The patch generated 694 new + 6087 unchanged - 74 fixed = 6781 total (was 6161)
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 52s	the patch passed
-1 ❌	spotbugs	3m 21s	phoenix-core generated 6 new + 959 unchanged - 0 fixed = 965 total (was 959)
		_ Other Tests _
-1 ❌	unit	111m 37s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 46s	The patch does not generate ASF License warnings.
		170m 33s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.NoOpTableMetricsManager.noOpsTableMetricManager isn't final but should be At NoOpTableMetricsManager.java:be At NoOpTableMetricsManager.java:[line 30]
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1224
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname	Linux 5d9237fe425a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `6c22b43`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/8/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/8/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/8/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/8/testReport/
Max. process+thread count	15295 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/8/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-12T07:14:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	16m 46s	master passed
+0	hbaserecompile	23m 9s	HBase recompiled.
+1 💚	compile	1m 2s	master passed
+1 💚	checkstyle	3m 6s	master passed
+1 💚	javadoc	0m 50s	master passed
+0 🆗	spotbugs	3m 5s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 6s	the patch passed
+0	hbaserecompile	17m 31s	HBase recompiled.
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
-1 ❌	checkstyle	3m 19s	phoenix-core: The patch generated 694 new + 6087 unchanged - 74 fixed = 6781 total (was 6161)
+1 💚	whitespace	0m 1s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 52s	the patch passed
-1 ❌	spotbugs	3m 18s	phoenix-core generated 5 new + 959 unchanged - 0 fixed = 964 total (was 959)
		_ Other Tests _
-1 ❌	unit	114m 14s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 49s	The patch does not generate ASF License warnings.
		173m 38s

Reason	Tests
FindBugs	module:phoenix-core
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]
Failed junit tests	phoenix.end2end.BackwardCompatibilityIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1224
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname	Linux b03a595dfbf2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `6c22b43`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/9/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/9/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/9/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/9/testReport/
Max. process+thread count	14460 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/9/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-12T18:33:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	17m 8s	master passed
+0	hbaserecompile	24m 17s	HBase recompiled.
+1 💚	compile	1m 4s	master passed
+1 💚	checkstyle	2m 42s	master passed
+1 💚	javadoc	0m 50s	master passed
+0 🆗	spotbugs	3m 9s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 11s	the patch passed
+0	hbaserecompile	18m 48s	HBase recompiled.
+1 💚	compile	1m 7s	the patch passed
+1 💚	javac	1m 7s	the patch passed
-1 ❌	checkstyle	2m 55s	phoenix-core: The patch generated 694 new + 6087 unchanged - 74 fixed = 6781 total (was 6161)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 57s	the patch passed
-1 ❌	spotbugs	3m 39s	phoenix-core generated 5 new + 959 unchanged - 0 fixed = 964 total (was 959)
		_ Other Tests _
-1 ❌	unit	113m 26s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 45s	The patch does not generate ASF License warnings.
		174m 34s

Reason	Tests
FindBugs	module:phoenix-core
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]
Failed junit tests	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/10/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1224
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname	Linux 4f3a0c5839f8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `6c22b43`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/10/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/10/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/10/testReport/
Max. process+thread count	15826 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/10/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-13T02:26:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 3 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	16m 8s	master passed
+0	hbaserecompile	22m 53s	HBase recompiled.
+1 💚	compile	1m 4s	master passed
+1 💚	checkstyle	3m 6s	master passed
+1 💚	javadoc	0m 59s	master passed
+0 🆗	spotbugs	3m 5s	phoenix-core in master has 960 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 12s	the patch passed
+0	hbaserecompile	18m 8s	HBase recompiled.
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
-1 ❌	checkstyle	3m 29s	phoenix-core: The patch generated 701 new + 6087 unchanged - 74 fixed = 6788 total (was 6161)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	javadoc	0m 49s	the patch passed
-1 ❌	spotbugs	3m 20s	phoenix-core generated 5 new + 960 unchanged - 0 fixed = 965 total (was 960)
		_ Other Tests _
-1 ❌	unit	113m 1s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 46s	The patch does not generate ASF License warnings.
		172m 30s

Reason	Tests
FindBugs	module:phoenix-core
	Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58]
	Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61]
Failed junit tests	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/11/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1224
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname	Linux f66894b3dc95 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `df32aec`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/11/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/11/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/11/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/11/testReport/
Max. process+thread count	16027 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1224/11/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

PHOENIX-6397Implement TableMetricsManager class and its associated f…
dda5107
…unctions for select. upsert and Delete Queries