PHOENIX-6457 - Optionally store schema version string in SYSTEM.CATALOG

[gjacoby126]

No description provided.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 1s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	17m 38s	master passed
+0	hbaserecompile	25m 42s	HBase recompiled.
+1 💚	compile	1m 7s	master passed
+1 💚	checkstyle	4m 6s	master passed
+1 💚	javadoc	0m 59s	master passed
+0 🆗	spotbugs	3m 42s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	9m 19s	the patch passed
+0	hbaserecompile	20m 25s	HBase recompiled.
+1 💚	compile	1m 1s	the patch passed
+1 💚	cc	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
-1 ❌	checkstyle	4m 57s	phoenix-core: The patch generated 75 new + 10362 unchanged - 25 fixed = 10437 total (was 10387)
+1 💚	prototool	0m 1s	There were no new prototool issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 51s	the patch passed
-1 ❌	spotbugs	3m 14s	phoenix-core generated 1 new + 958 unchanged - 1 fixed = 959 total (was 959)
		_ Other Tests _
-1 ❌	unit	113m 42s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 39s	The patch does not generate ASF License warnings.
		180m 35s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SCHEMA_VERSION_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 352]
Failed junit tests	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
	phoenix.end2end.UpsertSelectIT
	phoenix.end2end.PermissionsCacheIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1225
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile cc prototool
uname	Linux 88557b5e1191 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 5265164
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/1/testReport/
Max. process+thread count	13523 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 1s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	19m 14s	master passed
+0	hbaserecompile	28m 12s	HBase recompiled.
+1 💚	compile	1m 13s	master passed
+1 💚	checkstyle	3m 55s	master passed
+1 💚	javadoc	1m 3s	master passed
+0 🆗	spotbugs	4m 10s	phoenix-core in master has 959 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	11m 31s	the patch passed
+0	hbaserecompile	24m 17s	HBase recompiled.
+1 💚	compile	1m 24s	the patch passed
+1 💚	cc	1m 24s	the patch passed
+1 💚	javac	1m 24s	the patch passed
-1 ❌	checkstyle	4m 15s	phoenix-core: The patch generated 102 new + 10335 unchanged - 52 fixed = 10437 total (was 10387)
+1 💚	prototool	0m 3s	There were no new prototool issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	1m 1s	the patch passed
-1 ❌	spotbugs	4m 31s	phoenix-core generated 1 new + 958 unchanged - 1 fixed = 959 total (was 959)
		_ Other Tests _
-1 ❌	unit	115m 38s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 46s	The patch does not generate ASF License warnings.
		190m 20s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SCHEMA_VERSION_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 352]
Failed junit tests	phoenix.end2end.AuditLoggingIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1225
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile cc prototool
uname	Linux d63285ec87df 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 88a0128
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/2/testReport/
Max. process+thread count	14975 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1225/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[gjacoby126]

The initial 3 test failures from the first test run passed in the second. I verified that AuditLoggingIT (failed in the second test run) passed locally, so this appears to be a flapper. I also verified UpsertSelectIT from the initial test failure locally and it passed.

[gjacoby126]

Merging without review since this is a trivial port of an approved PR #1216