Skip to content

PHOENIX-6454: Add feature to SchemaTool to get the DDL in specificati… - #1229

Merged
swaroopak merged 1 commit into
apache:masterfrom
swaroopak:PHOENIX-6454_master
May 14, 2021
Merged

PHOENIX-6454: Add feature to SchemaTool to get the DDL in specificati…#1229
swaroopak merged 1 commit into
apache:masterfrom
swaroopak:PHOENIX-6454_master

Conversation

@swaroopak

Copy link
Copy Markdown
Contributor

…on mode (#1217)

Co-authored-by: Swaroopa Kadam s.kadam@apache.org

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep4m 58sMaven dependency ordering for branch
+1 💚mvninstall11m 50smaster passed
+0hbaserecompile24m 12sHBase recompiled.
+1 💚compile1m 34smaster passed
+1 💚checkstyle1m 0smaster passed
+1 💚javadoc1m 12smaster passed
+0 🆗spotbugs3m 7sphoenix-core in master has 960 extant spotbugs warnings.
+0 🆗spotbugs0m 44sphoenix-tools in master has 3 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
-1 ❌mvninstall0m 30sroot in the patch failed.
+0hbaserecompile7m 55sHBase recompiled.
-1 ❌compile0m 21sphoenix-core in the patch failed.
-1 ❌compile0m 16sphoenix-tools in the patch failed.
-1 ❌javac0m 21sphoenix-core in the patch failed.
-1 ❌javac0m 16sphoenix-tools in the patch failed.
-1 ❌checkstyle0m 38sphoenix-core: The patch generated 32 new + 208 unchanged - 3 fixed = 240 total (was 211)
-1 ❌checkstyle0m 24sphoenix-tools: The patch generated 185 new + 221 unchanged - 41 fixed = 406 total (was 262)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 11sthe patch passed
-1 ❌spotbugs0m 18sphoenix-core in the patch failed.
-1 ❌spotbugs0m 15sphoenix-tools in the patch failed.
_ Other Tests _
-1 ❌unit0m 19sphoenix-core in the patch failed.
-1 ❌unit0m 16sphoenix-tools in the patch failed.
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
50m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1229
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux f89f9d51463c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / df32aec
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstallhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
compilehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt
javachttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
javachttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-tools.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/testReport/
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: phoenix-core phoenix-tools U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@swaroopak
swaroopakforce-pushed the PHOENIX-6454_master branch from e6c0b8b to 9c9b27bCompareMay 13, 2021 16:54
@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep4m 56sMaven dependency ordering for branch
+1 💚mvninstall12m 44smaster passed
+0hbaserecompile24m 40sHBase recompiled.
+1 💚compile1m 39smaster passed
+1 💚checkstyle0m 53smaster passed
+1 💚javadoc1m 13smaster passed
+0 🆗spotbugs3m 25sphoenix-core in master has 960 extant spotbugs warnings.
+0 🆗spotbugs0m 42sphoenix-tools in master has 3 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
-1 ❌mvninstall0m 32sroot in the patch failed.
+0hbaserecompile10m 18sHBase recompiled.
-1 ❌compile0m 22sphoenix-core in the patch failed.
-1 ❌compile0m 31sphoenix-tools in the patch failed.
-1 ❌javac0m 22sphoenix-core in the patch failed.
-1 ❌javac0m 31sphoenix-tools in the patch failed.
-1 ❌checkstyle0m 55sphoenix-core: The patch generated 32 new + 208 unchanged - 3 fixed = 240 total (was 211)
-1 ❌checkstyle0m 24sphoenix-tools: The patch generated 157 new + 249 unchanged - 13 fixed = 406 total (was 262)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 27sthe patch passed
-1 ❌spotbugs0m 20sphoenix-core in the patch failed.
-1 ❌spotbugs0m 33sphoenix-tools in the patch failed.
_ Other Tests _
-1 ❌unit0m 21sphoenix-core in the patch failed.
-1 ❌unit0m 34sphoenix-tools in the patch failed.
+1 💚asflicense0m 30sThe patch does not generate ASF License warnings.
55m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1229
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux d216818e5e73 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / df32aec
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstallhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
compilehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt
javachttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
javachttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix-tools.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/testReport/
Max. process+thread count84 (vs. ulimit of 30000)
modulesC: phoenix-core phoenix-tools U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@swaroopak
swaroopakforce-pushed the PHOENIX-6454_master branch from 9c9b27b to 6a44538CompareMay 14, 2021 03:15
@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 1sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep6m 8sMaven dependency ordering for branch
+1 💚mvninstall13m 16smaster passed
+0hbaserecompile27m 28sHBase recompiled.
+1 💚compile1m 33smaster passed
+1 💚checkstyle0m 54smaster passed
+1 💚javadoc1m 9smaster passed
+0 🆗spotbugs3m 21sphoenix-core in master has 965 extant spotbugs warnings.
+0 🆗spotbugs0m 42sphoenix-tools in master has 3 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall9m 48sthe patch passed
+0hbaserecompile16m 43sHBase recompiled.
+1 💚compile1m 35sthe patch passed
+1 💚javac1m 35sthe patch passed
-1 ❌checkstyle0m 39sphoenix-core: The patch generated 43 new + 359 unchanged - 9 fixed = 402 total (was 368)
-1 ❌checkstyle0m 19sphoenix-tools: The patch generated 166 new + 249 unchanged - 13 fixed = 415 total (was 262)
-1 ❌whitespace0m 0sThe patch 2 line(s) with tabs.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc1m 10sthe patch passed
-1 ❌spotbugs0m 57sphoenix-tools generated 5 new + 0 unchanged - 3 fixed = 5 total (was 3)
_ Other Tests _
-1 ❌unit128m 49sphoenix-core in the patch failed.
-1 ❌unit4m 48sphoenix-tools in the patch failed.
-1 ❌asflicense1m 44sThe patch generated 1 ASF License warnings.
200m 46s
ReasonTests
FindBugsmodule:phoenix-tools
Found reliance on default encoding in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String):in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String): new java.io.FileReader(File) At SchemaSynthesisProcessor.java:[line 212]
org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String) may fail to close stream At SchemaSynthesisProcessor.java:stream At SchemaSynthesisProcessor.java:[line 212]
org.apache.phoenix.schema.SchemaTool.conf should be package protected In SchemaTool.java: In SchemaTool.java
Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:[line 114]
Write to static field org.apache.phoenix.schema.SchemaTool.conf from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:[line 73]
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1229
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml
unameLinux 3c1c37373577 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 877457e
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
whitespacehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/whitespace-tabs.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-tools.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/testReport/
asflicensehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count8265 (vs. ulimit of 30000)
modulesC: phoenix-core phoenix-tools U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@swaroopak
swaroopak merged commit eeebc8e into apache:masterMay 14, 2021
richardantal pushed a commit to richardantal/phoenix-1 that referenced this pull request Jul 22, 2021
…on mode (apache#1229)
Co-authored-by: Swaroopa Kadam <s.kadam@apache.org>
richardantal pushed a commit that referenced this pull request Jul 29, 2021
…on mode (#1229)
Co-authored-by: Swaroopa Kadam <s.kadam@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@swaroopak@stoty