PHOENIX-5838 Add Histograms for Table level Metrics by vmeka2020 · Pull Request #1231 · apache/phoenix

vmeka2020 · 2021-05-14T05:54:19Z

No description provided.

vmeka2020 · 2021-05-14T06:01:17Z

stoty · 2021-05-14T08:49:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 5 new or modified test files.
		_ 4.x Compile Tests _
+0 🆗	mvndep	5m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	9m 44s	4.x passed
+1 💚	compile	1m 34s	4.x passed
+1 💚	checkstyle	2m 25s	4.x passed
+1 💚	javadoc	2m 5s	4.x passed
+0 🆗	spotbugs	4m 44s	root in 4.x has 1020 extant spotbugs warnings.
+0 🆗	spotbugs	3m 17s	phoenix-core in 4.x has 951 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 23s	the patch passed
+1 💚	compile	1m 36s	the patch passed
+1 💚	javac	1m 36s	the patch passed
-1 ❌	checkstyle	2m 33s	root: The patch generated 336 new + 5876 unchanged - 4 fixed = 6212 total (was 5880)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	javadoc	2m 1s	the patch passed
-1 ❌	spotbugs	3m 34s	phoenix-core generated 4 new + 951 unchanged - 0 fixed = 955 total (was 951)
-1 ❌	spotbugs	4m 56s	root generated 4 new + 1020 unchanged - 0 fixed = 1024 total (was 1020)
		_ Other Tests _
-1 ❌	unit	118m 58s	root in the patch failed.
+1 💚	asflicense	0m 54s	The patch does not generate ASF License warnings.
		174m 8s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
	org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75]
	new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41]
	org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
FindBugs	module:root
	org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
	org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75]
	new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41]
	org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
Failed junit tests	phoenix.end2end.RegexpSubstrFunctionIT
	phoenix.end2end.StringToArrayFunctionIT
	phoenix.end2end.RegexpSplitFunctionIT
	phoenix.end2end.WALAnnotationIT
	phoenix.end2end.OnDuplicateKeyIT
	phoenix.end2end.index.ImmutableIndexWithStatsIT
	phoenix.end2end.ReverseFunctionIT
	phoenix.end2end.index.LocalImmutableTxIndexIT
	phoenix.end2end.DropTableWithViewsIT
	phoenix.end2end.PhoenixRuntimeIT
	phoenix.end2end.AutoCommitIT
	phoenix.schema.stats.NamespaceEnabledStatsCollectorIT
	phoenix.end2end.TimezoneOffsetFunctionIT
	phoenix.end2end.ExplainPlanWithStatsDisabledIT
	phoenix.end2end.SqrtFunctionEnd2EndIT
	phoenix.end2end.join.SortMergeJoinNoSpoolingIT
	phoenix.end2end.PhoenixRowTimestampFunctionIT
	phoenix.end2end.MathTrigFunctionEnd2EndIT
	phoenix.end2end.AutoPartitionViewsIT
	phoenix.end2end.AppendOnlySchemaIT
	phoenix.end2end.OrderByIT
	phoenix.end2end.ReadOnlyIT
	phoenix.end2end.ArrayFillFunctionIT
	phoenix.end2end.index.GlobalIndexCheckerIT
	phoenix.end2end.CustomEntityDataIT
	phoenix.end2end.index.PartialIndexRebuilderIT
	phoenix.end2end.join.WhereOptimizerForJoinFiltersIT
	phoenix.end2end.PermissionNSEnabledIT
	phoenix.end2end.ServerExceptionIT
	phoenix.util.IndexScrutinyIT
	phoenix.end2end.SpillableGroupByIT
	phoenix.end2end.LnLogFunctionEnd2EndIT
	phoenix.end2end.TenantSpecificViewIndexIT
	phoenix.end2end.QueryWithLimitIT
	phoenix.end2end.RowTimestampIT
	phoenix.end2end.DateArithmeticIT
	phoenix.end2end.TruncateFunctionIT
	phoenix.end2end.ColumnProjectionOptimizationIT
	phoenix.end2end.join.HashJoinNoIndexIT
	phoenix.end2end.CursorWithRowValueConstructorIT
	phoenix.end2end.DropSchemaIT
	phoenix.end2end.index.ViewIndexIT
	phoenix.end2end.UpsertSelectIT
	phoenix.end2end.OperationTimeoutWithReasonIT
	phoenix.end2end.index.IndexAsyncThresholdIT
	phoenix.end2end.index.MutableIndexRebuilderIT
	phoenix.end2end.index.GlobalImmutableNonTxIndexIT
	phoenix.end2end.IndexBuildTimestampIT
	phoenix.end2end.MigrateSystemTablesToSystemNamespaceIT
	phoenix.end2end.ParallelIteratorsIT
	phoenix.tx.ParameterizedTransactionIT
	phoenix.tx.TxCheckpointIT
	phoenix.end2end.Array2IT
	phoenix.end2end.DropTableIT
	phoenix.rpc.UpdateCacheIT
	phoenix.end2end.ClientHashAggregateIT
	phoenix.end2end.CsvBulkLoadToolIT
	phoenix.end2end.AlterTableWithViewsIT
	phoenix.end2end.StringIT
	phoenix.end2end.SequenceIT
	phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT
	phoenix.end2end.PartialScannerResultsDisabledIT
	phoenix.end2end.join.HashJoinCacheIT
	phoenix.iterate.ScannerLeaseRenewalIT
	phoenix.end2end.RowKeyBytesStringFunctionIT
	phoenix.end2end.ImmutableTableIT
	phoenix.rpc.UpdateCacheConnectionLevelPropIT
	phoenix.end2end.ExecuteStatementsIT
	phoenix.end2end.RTrimFunctionIT
	phoenix.end2end.index.GlobalMutableNonTxIndexWithLazyPostBatchWriteIT
	phoenix.end2end.LikeExpressionIT
	phoenix.iterate.RoundRobinResultIteratorIT
	phoenix.end2end.index.IndexMaintenanceIT
	phoenix.end2end.index.MutableIndexSplitReverseScanIT
	phoenix.end2end.TenantSpecificTablesDMLIT
	phoenix.end2end.RowValueConstructorIT
	phoenix.end2end.index.MutableIndexFailureWithNamespaceIT
	phoenix.end2end.AggregateIT
	phoenix.end2end.BackwardCompatibilityForSplittableSyscatIT
	phoenix.end2end.BackwardCompatibilityIT
	phoenix.end2end.DynamicFamilyIT
	phoenix.end2end.QueryWithTableSampleIT
	phoenix.coprocessor.StatisticsCollectionRunTrackerIT
	phoenix.end2end.ToCharFunctionIT
	phoenix.end2end.LogicalTableNameExtendedIT
	phoenix.end2end.join.SortMergeJoinLocalIndexIT
	phoenix.end2end.CostBasedDecisionIT
	phoenix.end2end.UpsertSelectAutoCommitIT
	phoenix.end2end.index.IndexUsageIT
	phoenix.end2end.index.IndexVerificationOutputRepositoryIT
	phoenix.end2end.index.MutableIndexExtendedIT
	phoenix.end2end.UpgradeIT
	phoenix.end2end.NthValueFunctionIT
	phoenix.end2end.PropertiesInSyncIT
	phoenix.end2end.ViewTTLIT
	phoenix.end2end.ModulusExpressionIT
	phoenix.end2end.UpsertValuesIT
	phoenix.end2end.join.HashJoinPersistentCacheIT
	phoenix.end2end.OctetLengthFunctionEnd2EndIT
	phoenix.end2end.IndexToolIT
	phoenix.end2end.SortMergeJoinMoreIT
	phoenix.end2end.index.MutableIndexSplitForwardScanIT
	phoenix.tx.FlappingTransactionIT
	phoenix.end2end.index.ChildViewsUseParentViewIndexIT
	phoenix.end2end.index.MutableIndexIT
	phoenix.end2end.MutationStateIT
	phoenix.end2end.SkipScanQueryIT
	phoenix.iterate.RoundRobinResultIteratorWithStatsIT
	phoenix.end2end.ArrayAppendFunctionIT
	phoenix.end2end.DistinctCountIT
	phoenix.end2end.index.GlobalImmutableTxIndexIT
	phoenix.end2end.SystemTablesCreationOnConnectionIT
	phoenix.end2end.ReverseScanIT
	phoenix.end2end.ParameterizedIndexUpgradeToolIT
	phoenix.end2end.IndexRebuildTaskIT
	phoenix.end2end.UnionAllIT
	phoenix.schema.stats.TxStatsCollectorIT
	phoenix.end2end.ConcurrentMutationsIT
	phoenix.end2end.MaxLookbackIT
	phoenix.monitoring.PhoenixLoggingMetricsIT
	phoenix.end2end.EvaluationOfORIT
	phoenix.end2end.TenantIdTypeIT
	phoenix.end2end.SkipScanAfterManualSplitIT
	phoenix.end2end.NoLookbackMutableIndexExtendedIT
	phoenix.end2end.join.SortMergeJoinGlobalIndexIT
	phoenix.end2end.QueryWithOffsetIT
	phoenix.end2end.DeleteIT
	phoenix.end2end.ArrayRemoveFunctionIT
	phoenix.end2end.index.txn.RollbackIT
	phoenix.tx.TransactionIT
	phoenix.end2end.ArraysWithNullsIT
	phoenix.end2end.CountDistinctApproximateHyperLogLogIT
	phoenix.end2end.AlterTableIT
	phoenix.end2end.AlterMultiTenantTableWithViewsIT
	phoenix.end2end.join.SortMergeJoinNoIndexIT
	phoenix.end2end.index.LocalMutableNonTxIndexIT
	phoenix.end2end.InstrFunctionIT
	phoenix.end2end.index.MutableIndexFailureIT
	phoenix.end2end.DefaultColumnValueIT
	phoenix.end2end.VariableLengthPKIT
	phoenix.end2end.ProjectArrayElemAfterHashJoinIT
	phoenix.end2end.index.LocalMutableTxIndexIT
	phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
	hadoop.hbase.regionserver.wal.WALRecoveryRegionPostOpenIT
	phoenix.end2end.OrphanViewToolIT
	phoenix.end2end.index.GlobalMutableTxIndexIT
	phoenix.end2end.UpsertBigValuesIT
	phoenix.rpc.PhoenixClientRpcIT
	phoenix.iterate.ChunkedResultIteratorIT
	phoenix.end2end.TransactionalViewIT
	phoenix.end2end.join.HashJoinLocalIndexIT
	phoenix.end2end.Array1IT
	phoenix.end2end.index.SaltedIndexIT
	phoenix.execute.UpsertSelectOverlappingBatchesIT
	phoenix.end2end.ExplainPlanWithStatsEnabledIT
	phoenix.end2end.CreateTableIT
	phoenix.end2end.index.DropColumnIT
	phoenix.end2end.salted.SaltedTableUpsertSelectIT
	phoenix.end2end.index.IndexWithTableSchemaChangeIT
	phoenix.end2end.ConfigurableCacheIT
	phoenix.end2end.CbrtFunctionEnd2EndIT
	phoenix.end2end.AuditLoggingIT
	phoenix.end2end.MergeViewIndexIdSequencesToolIT
	phoenix.end2end.IndexToolForNonTxGlobalIndexIT
	phoenix.end2end.DistinctPrefixFilterIT
	phoenix.end2end.SCNIT
	phoenix.end2end.OrderByWithServerClientSpoolingDisabledIT
	phoenix.end2end.SerialIteratorsIT
	phoenix.end2end.ContextClassloaderIT
	phoenix.end2end.IndexExtendedIT
	phoenix.end2end.AbsFunctionEnd2EndIT
	phoenix.end2end.ArrayPrependFunctionIT
	phoenix.end2end.ViewMetadataIT
	phoenix.end2end.PartialResultServerConfigurationIT
	phoenix.end2end.PrimitiveTypeIT
	phoenix.end2end.DescOrderKeysIT
	phoenix.end2end.DynamicUpsertIT
	phoenix.end2end.ConcurrentMutationsExtendedIT
	phoenix.execute.PartialCommitIT
	phoenix.end2end.FirstValueFunctionIT
	phoenix.end2end.index.ImmutableIndexExtendedIT
	phoenix.end2end.IndexToolForPartialBuildIT
	phoenix.trace.PhoenixTableMetricsWriterIT
	phoenix.end2end.LastValueFunctionIT
	phoenix.end2end.index.ImmutableIndexIT
	phoenix.end2end.DynamicColumnIT
	phoenix.end2end.IndexToolForDeleteBeforeRebuildIT
	phoenix.schema.stats.NoOpStatsCollectorIT
	phoenix.end2end.ArrayConcatFunctionIT
	phoenix.end2end.TenantSpecificTablesDDLIT
	phoenix.end2end.salted.SaltedTableIT
	phoenix.end2end.PercentileIT
	phoenix.end2end.QueryMoreIT
	phoenix.end2end.CSVCommonsLoaderIT
	phoenix.end2end.index.GlobalIndexOptimizationIT
	phoenix.end2end.RowValueConstructorOffsetIT
	phoenix.end2end.ArithmeticQueryIT
	phoenix.iterate.PhoenixQueryTimeoutIT
	phoenix.end2end.PointInTimeScanQueryIT
	phoenix.end2end.join.HashJoinGlobalIndexIT
	phoenix.end2end.SignFunctionEnd2EndIT
	phoenix.end2end.join.SubqueryUsingSortMergeJoinIT
	phoenix.end2end.EmptyColumnIT
	phoenix.end2end.index.GlobalMutableNonTxIndexIT
	phoenix.end2end.ArrayToStringFunctionIT
	phoenix.end2end.ViewIT
	phoenix.end2end.QueryLoggerIT
	phoenix.monitoring.PhoenixMetricsIT
	phoenix.end2end.CoalesceFunctionIT
	phoenix.end2end.SystemCatalogRollbackEnabledIT
	phoenix.end2end.AlterAddCascadeIndexIT
	phoenix.end2end.index.SingleCellIndexIT
	phoenix.end2end.PermissionsCacheIT
	phoenix.end2end.QueryTimeoutIT
	phoenix.end2end.IndexVerificationOldDesignIT
	phoenix.end2end.RoundFloorCeilFuncIT
	phoenix.rpc.PhoenixServerRpcIT
	phoenix.end2end.ToDateFunctionIT
	phoenix.end2end.index.txn.MutableRollbackIT
	phoenix.end2end.IndexScrutinyToolForTenantIT
	phoenix.end2end.index.AsyncIndexDisabledIT
	phoenix.end2end.PermissionNSDisabledIT
	phoenix.end2end.MinMaxAggregateFunctionIT
	phoenix.end2end.index.LocalIndexIT
	phoenix.end2end.GetSetByteBitFunctionEnd2EndIT
	phoenix.end2end.IndexScrutinyToolIT
	phoenix.end2end.InListIT
	phoenix.end2end.salted.SaltedTableVarLengthRowKeyIT
	phoenix.end2end.StatsEnabledSplitSystemCatalogIT
	phoenix.end2end.index.txn.TxWriteFailureIT
	phoenix.end2end.UserDefinedFunctionsIT
	phoenix.query.MaxConcurrentConnectionsIT
	phoenix.end2end.index.PhoenixMRJobSubmitterIT
	phoenix.end2end.index.IndexMetadataIT
	phoenix.end2end.IsNullIT
	phoenix.end2end.ToNumberFunctionIT
	phoenix.end2end.TenantSpecificViewIndexSaltedIT
	phoenix.end2end.SpooledTmpFileDeleteIT
	phoenix.end2end.UngroupedIT
	phoenix.end2end.index.AlterIndexIT
	phoenix.end2end.IndexRepairRegionScannerIT
	phoenix.end2end.FlappingLocalIndexIT
	phoenix.end2end.RegexpReplaceFunctionIT
	phoenix.end2end.ViewConcurrencyAndFailureIT
	phoenix.end2end.IndexToolTimeRangeIT
	phoenix.end2end.DisableLocalIndexIT
	phoenix.end2end.UpsertWithSCNIT
	phoenix.end2end.OrderByWithSpillingIT
	phoenix.end2end.QueryDatabaseMetaDataIT
	phoenix.end2end.ColumnEncodedBytesPropIT
	phoenix.end2end.BinaryRowKeyIT
	phoenix.end2end.DropIndexedColsIT
	phoenix.end2end.RegexBulkLoadToolIT
	phoenix.end2end.SortOrderIT
	phoenix.end2end.SequenceBulkAllocationIT
	phoenix.end2end.ConvertTimezoneFunctionIT
	phoenix.end2end.FirstValuesFunctionIT
	phoenix.end2end.MultiCfQueryExecIT
	phoenix.end2end.PointInTimeQueryIT
	phoenix.end2end.join.SubqueryIT
	phoenix.end2end.join.HashJoinMoreIT
	phoenix.end2end.KeyOnlyIT
	phoenix.end2end.IndexToolForPartialBuildWithNamespaceEnabledIT
	phoenix.end2end.ExpFunctionEnd2EndIT
	phoenix.schema.stats.NamespaceDisabledStatsCollectorIT
	phoenix.end2end.ReadIsolationLevelIT
	phoenix.end2end.Array3IT
	phoenix.end2end.FunkyNamesIT
	phoenix.end2end.OrderByWithServerMemoryLimitIT
	phoenix.end2end.index.MutableIndexReplicationIT
	phoenix.end2end.GroupByIT
	phoenix.schema.stats.NonTxStatsCollectorIT
	phoenix.end2end.LocalIndexSplitMergeIT
	phoenix.end2end.PhoenixTTLToolIT
	phoenix.end2end.index.ShortViewIndexIdIT
	phoenix.end2end.PowerFunctionEnd2EndIT
	phoenix.end2end.MapReduceIT
	phoenix.end2end.DateTimeIT
	phoenix.end2end.UseSchemaIT
	phoenix.end2end.MD5FunctionIT
	phoenix.end2end.ConnectionUtilIT
	phoenix.end2end.MetaDataEndpointImplIT
	phoenix.end2end.TopNIT
	phoenix.end2end.EncodeFunctionIT
	phoenix.end2end.TableSnapshotReadsMapReduceIT
	phoenix.end2end.StatementHintsIT
	phoenix.end2end.UpgradeNamespaceIT
	phoenix.end2end.RangeScanIT
	phoenix.end2end.StoreNullsIT
	phoenix.end2end.DecodeFunctionIT
	phoenix.end2end.LogicalTableNameIT
	phoenix.end2end.index.LocalImmutableNonTxIndexIT
	phoenix.end2end.CastAndCoerceIT
	phoenix.end2end.LastValuesFunctionIT
	phoenix.end2end.UpdateCacheAcrossDifferentClientsIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1231
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle
uname	Linux e1135bdcd100 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `9e91e5c`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/1/artifact/yetus-general-check/output/new-spotbugs-root.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/1/testReport/
Max. process+thread count	5423 (vs. ulimit of 30000)
modules	C: phoenix-core . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-15T03:28:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 5 new or modified test files.
		_ 4.x Compile Tests _
+0 🆗	mvndep	5m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	10m 45s	4.x passed
+1 💚	compile	1m 53s	4.x passed
+1 💚	checkstyle	2m 9s	4.x passed
+1 💚	javadoc	2m 8s	4.x passed
+0 🆗	spotbugs	4m 48s	root in 4.x has 1020 extant spotbugs warnings.
+0 🆗	spotbugs	3m 23s	phoenix-core in 4.x has 951 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	7m 13s	the patch passed
+1 💚	compile	1m 42s	the patch passed
+1 💚	javac	1m 42s	the patch passed
-1 ❌	checkstyle	2m 8s	root: The patch generated 340 new + 5885 unchanged - 6 fixed = 6225 total (was 5891)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	javadoc	2m 14s	the patch passed
-1 ❌	spotbugs	3m 52s	phoenix-core generated 4 new + 951 unchanged - 0 fixed = 955 total (was 951)
-1 ❌	spotbugs	5m 24s	root generated 4 new + 1020 unchanged - 0 fixed = 1024 total (was 1020)
		_ Other Tests _
-1 ❌	unit	216m 21s	root in the patch failed.
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		278m 6s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
	org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75]
	new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41]
	org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
FindBugs	module:root
	org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
	org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75]
	new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41]
	org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
Failed junit tests	phoenix.pherf.PherfMainIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1231
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle
uname	Linux d2247b640176 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `0e2b826`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/3/artifact/yetus-general-check/output/new-spotbugs-root.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/3/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/3/testReport/
Max. process+thread count	5259 (vs. ulimit of 30000)
modules	C: phoenix-core . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/3/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

nsgupta1

+1 !!! Looks good to me except for a couples of nits.

stoty · 2021-05-19T23:29:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 5 new or modified test files.
		_ 4.x Compile Tests _
+0 🆗	mvndep	5m 49s	Maven dependency ordering for branch
+1 💚	mvninstall	10m 28s	4.x passed
+1 💚	compile	1m 38s	4.x passed
+1 💚	checkstyle	2m 8s	4.x passed
+1 💚	javadoc	1m 59s	4.x passed
+0 🆗	spotbugs	4m 41s	root in 4.x has 1020 extant spotbugs warnings.
+0 🆗	spotbugs	3m 39s	phoenix-core in 4.x has 951 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	8m 7s	the patch passed
+1 💚	compile	1m 49s	the patch passed
+1 💚	javac	1m 49s	the patch passed
-1 ❌	checkstyle	2m 43s	root: The patch generated 383 new + 5842 unchanged - 49 fixed = 6225 total (was 5891)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 4s	The patch has no ill-formed XML file.
+1 💚	javadoc	2m 20s	the patch passed
-1 ❌	spotbugs	3m 35s	phoenix-core generated 4 new + 951 unchanged - 0 fixed = 955 total (was 951)
-1 ❌	spotbugs	4m 53s	root generated 4 new + 1020 unchanged - 0 fixed = 1024 total (was 1020)
		_ Other Tests _
-1 ❌	unit	212m 28s	root in the patch failed.
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		270m 9s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
	org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75]
	new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41]
	org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
FindBugs	module:root
	org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
	org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75]
	new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41]
	org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
Failed junit tests	phoenix.pherf.PherfMainIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1231
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle
uname	Linux 7b4476c7a37b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `69a9ec3`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/artifact/yetus-general-check/output/new-spotbugs-root.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/testReport/
Max. process+thread count	4997 (vs. ulimit of 30000)
modules	C: phoenix-core . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/4/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-20T03:45:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 5 new or modified test files.
		_ 4.x Compile Tests _
+0 🆗	mvndep	5m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	10m 36s	4.x passed
+1 💚	compile	1m 39s	4.x passed
+1 💚	checkstyle	2m 10s	4.x passed
+1 💚	javadoc	2m 2s	4.x passed
+0 🆗	spotbugs	4m 42s	root in 4.x has 1020 extant spotbugs warnings.
+0 🆗	spotbugs	3m 14s	phoenix-core in 4.x has 951 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for patch
+1 💚	mvninstall	7m 21s	the patch passed
+1 💚	compile	1m 38s	the patch passed
+1 💚	javac	1m 38s	the patch passed
-1 ❌	checkstyle	2m 11s	root: The patch generated 340 new + 5920 unchanged - 6 fixed = 6260 total (was 5926)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	javadoc	2m 3s	the patch passed
-1 ❌	spotbugs	3m 29s	phoenix-core generated 4 new + 951 unchanged - 0 fixed = 955 total (was 951)
-1 ❌	spotbugs	4m 50s	root generated 4 new + 1020 unchanged - 0 fixed = 1024 total (was 1020)
		_ Other Tests _
-1 ❌	unit	197m 35s	root in the patch failed.
+1 💚	asflicense	1m 17s	The patch does not generate ASF License warnings.
		255m 4s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
	org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75]
	new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41]
	org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
FindBugs	module:root
	org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
	org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75]
	new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41]
	org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
Failed junit tests	phoenix.monitoring.PhoenixTableLevelMetricsIT
	phoenix.end2end.AuditLoggingIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1231
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle
uname	Linux 2163d077c89f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `69a9ec3`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/5/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/5/artifact/yetus-general-check/output/new-spotbugs-root.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/5/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/5/testReport/
Max. process+thread count	5252 (vs. ulimit of 30000)
modules	C: phoenix-core . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/5/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-05-20T08:34:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 5 new or modified test files.
		_ 4.x Compile Tests _
+0 🆗	mvndep	5m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	10m 31s	4.x passed
+1 💚	compile	1m 41s	4.x passed
+1 💚	checkstyle	2m 6s	4.x passed
+1 💚	javadoc	1m 57s	4.x passed
+0 🆗	spotbugs	4m 40s	root in 4.x has 1020 extant spotbugs warnings.
+0 🆗	spotbugs	3m 15s	phoenix-core in 4.x has 951 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	7m 0s	the patch passed
+1 💚	compile	1m 39s	the patch passed
+1 💚	javac	1m 39s	the patch passed
-1 ❌	checkstyle	2m 16s	root: The patch generated 383 new + 5877 unchanged - 49 fixed = 6260 total (was 5926)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	javadoc	1m 58s	the patch passed
-1 ❌	spotbugs	3m 33s	phoenix-core generated 4 new + 951 unchanged - 0 fixed = 955 total (was 951)
-1 ❌	spotbugs	4m 56s	root generated 4 new + 1020 unchanged - 0 fixed = 1024 total (was 1020)
		_ Other Tests _
-1 ❌	unit	192m 20s	root in the patch failed.
+1 💚	asflicense	1m 18s	The patch does not generate ASF License warnings.
		249m 11s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
	org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75]
	new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41]
	org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
FindBugs	module:root
	org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
	org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 75]
	new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 41]
	org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
Failed junit tests	phoenix.end2end.AuditLoggingIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1231
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle
uname	Linux 1e50b46f9dee 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `69a9ec3`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/artifact/yetus-general-check/output/new-spotbugs-root.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/testReport/
Max. process+thread count	5233 (vs. ulimit of 30000)
modules	C: phoenix-core . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/6/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

dbwong

Looks good for the most part. Some small refactoring and maybe a bit of unnecessary/legacy code.

vmeka2020 · 2021-10-08T21:37:56Z

@dbwong Test Results : https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1231/13/testReport/

yanxinyi · 2021-10-11T22:02:48Z

 * Interface for UnRegistering Publisher Method
 */
 void unregisterMetricProvider();
+


nit: remove the extra line. Given no changes in this file.

yanxinyi · 2021-10-11T22:02:54Z

 }
 return metricSupplier;
 }
+


nit: remove the extra line. Given no changes in this file.

yanxinyi · 2021-10-11T22:03:19Z

 * @return Sum of the values of the metric sampled since the last {@link #reset()} call.
 */
 public long getTotalSum();
+


nit: remove the extra line. Given no changes in this file.

nsgupta1 approved these changes May 17, 2021
View reviewed changes

dbwong reviewed Oct 4, 2021
View reviewed changes

dbwong reviewed Oct 8, 2021
View reviewed changes

Comment threadphoenix-core/src/main/java/org/apache/phoenix/monitoring/HistogramDistributionImpl.java Outdated
Comment threadphoenix-core/src/main/java/org/apache/phoenix/monitoring/TableHistograms.java Outdated

vmeka2020 added 14 commits October 7, 2021 18:17

PHOENIX-5838Add Histograms for Table level Metrics.
6aaf24d

fixing the testcases
c9d3a8d

addressing review comments
6e2080a

addressing review comments
2a35408

addressing review comments
8fc6e64

addressing review comments
f2ab540

Addressing Review comments
eeb5415

rebasing 4.x
b1baa60

Trigger Build
7e90fe5

addressing review comments
4c2b629

fixing checkstyle issue
3f249d3

fixing checkstyle issue
0104537

fixing checkstyle issue
0f15845

fixing checkstyle issue
7396f16

vmeka2020 added 2 commits October 8, 2021 15:36

Addressing review comments
8afaea7

Addressing spot check errors
3c0a0df

yanxinyi reviewed Oct 11, 2021
View reviewed changes

dbwong approved these changes Oct 11, 2021
View reviewed changes

yanxinyi merged commit 3ee00b6 into apache:4.xOct 11, 2021

Uh oh!

Conversation

vmeka2020 commented May 14, 2021

Uh oh!

vmeka2020 commented May 14, 2021

Uh oh!

stoty commented May 14, 2021

Uh oh!

stoty commented May 15, 2021

Uh oh!

nsgupta1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stoty commented May 19, 2021

Uh oh!

stoty commented May 20, 2021

Uh oh!

stoty commented May 20, 2021

Uh oh!

dbwong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vmeka2020 commented Oct 8, 2021

Uh oh!

yanxinyiOct 11, 2021

Choose a reason for hiding this comment

Uh oh!

yanxinyiOct 11, 2021

Choose a reason for hiding this comment

Uh oh!

yanxinyiOct 11, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants