Skip to content

PHOENIX-5838 Add Histograms for Table level Metrics - #1232

Merged
yanxinyi merged 11 commits into
apache:masterfrom
vmeka2020:HistogramsMaster
Oct 11, 2021
Merged

PHOENIX-5838 Add Histograms for Table level Metrics#1232
yanxinyi merged 11 commits into
apache:masterfrom
vmeka2020:HistogramsMaster

Conversation

@vmeka2020

@vmeka2020vmeka2020 commented May 14, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@stoty

stoty commented May 14, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 5 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep5m 0sMaven dependency ordering for branch
+1 💚mvninstall11m 14smaster passed
+0hbaserecompile22m 41sHBase recompiled.
+1 💚compile1m 28smaster passed
+1 💚checkstyle2m 33smaster passed
+1 💚javadoc2m 30smaster passed
+0 🆗spotbugs5m 28sroot in master has 1027 extant spotbugs warnings.
+0 🆗spotbugs3m 46sphoenix-core in master has 965 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall9m 56sthe patch passed
+0hbaserecompile17m 20sHBase recompiled.
+1 💚compile1m 44sthe patch passed
+1 💚javac1m 44sthe patch passed
-1 ❌checkstyle2m 25sroot: The patch generated 335 new + 5848 unchanged - 4 fixed = 6183 total (was 5852)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚javadoc2m 45sthe patch passed
-1 ❌spotbugs3m 58sphoenix-core generated 4 new + 965 unchanged - 0 fixed = 969 total (was 965)
-1 ❌spotbugs5m 41sroot generated 4 new + 1027 unchanged - 0 fixed = 1031 total (was 1027)
_ Other Tests _
-1 ❌unit92m 53sroot in the patch failed.
-1 ❌asflicense1m 19sThe patch generated 613 ASF License warnings.
175m 6s
ReasonTests
FindBugsmodule:phoenix-core
org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 76]
new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 42]
org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
FindBugsmodule:root
org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 76]
new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 42]
org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
Failed junit testsphoenix.end2end.index.GlobalMutableNonTxIndexWithLazyPostBatchWriteIT
phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT
phoenix.end2end.index.SaltedIndexIT
phoenix.end2end.DynamicFamilyIT
phoenix.end2end.index.IndexWithTableSchemaChangeIT
phoenix.end2end.DynamicUpsertIT
phoenix.end2end.SkipScanQueryIT
phoenix.end2end.ToCharFunctionIT
phoenix.end2end.ArrayAppendFunctionIT
phoenix.end2end.join.HashJoinNoIndexIT
phoenix.end2end.DisableLocalIndexIT
phoenix.end2end.CursorWithRowValueConstructorIT
phoenix.end2end.PointInTimeScanQueryIT
phoenix.end2end.QueryWithOffsetIT
phoenix.end2end.OnDuplicateKeyIT
phoenix.end2end.ImmutableTableIT
phoenix.end2end.AutoCommitIT
phoenix.end2end.IndexToolIT
phoenix.end2end.ToDateFunctionIT
phoenix.schema.stats.TxStatsCollectorIT
phoenix.end2end.RegexpReplaceFunctionIT
phoenix.iterate.RoundRobinResultIteratorIT
phoenix.end2end.MetaDataEndpointImplIT
phoenix.end2end.index.ImmutableIndexExtendedIT
phoenix.end2end.RangeScanIT
phoenix.tx.ParameterizedTransactionIT
phoenix.end2end.TenantSpecificTablesDMLIT
phoenix.end2end.TopNIT
phoenix.end2end.ServerExceptionIT
phoenix.end2end.StatsEnabledSplitSystemCatalogIT
phoenix.end2end.join.SortMergeJoinNoIndexIT
phoenix.end2end.MutationStateIT
phoenix.schema.stats.NonTxStatsCollectorIT
phoenix.end2end.ArithmeticQueryIT
phoenix.end2end.index.IndexMetadataIT
phoenix.end2end.LogicalTableNameIT
phoenix.end2end.IndexVerificationOldDesignIT
phoenix.end2end.SerialIteratorsIT
phoenix.end2end.OctetLengthFunctionEnd2EndIT
phoenix.end2end.ToNumberFunctionIT
phoenix.end2end.StringIT
phoenix.iterate.ScannerLeaseRenewalIT
phoenix.end2end.ReverseScanIT
phoenix.end2end.SortMergeJoinMoreIT
phoenix.end2end.CustomEntityDataIT
phoenix.end2end.index.MutableIndexFailureWithNamespaceIT
phoenix.end2end.DecodeFunctionIT
phoenix.end2end.FirstValueFunctionIT
phoenix.end2end.FirstValuesFunctionIT
phoenix.end2end.PermissionNSDisabledIT
phoenix.end2end.ReadOnlyIT
phoenix.end2end.CbrtFunctionEnd2EndIT
phoenix.end2end.join.WhereOptimizerForJoinFiltersIT
phoenix.tx.TransactionIT
phoenix.end2end.DescOrderKeysIT
phoenix.end2end.UseSchemaIT
phoenix.end2end.AlterTableWithViewsIT
phoenix.util.IndexScrutinyIT
phoenix.end2end.IndexRebuildTaskIT
phoenix.end2end.index.MutableIndexReplicationIT
phoenix.end2end.QueryWithTableSampleIT
phoenix.end2end.ClientHashAggregateIT
phoenix.end2end.CountDistinctApproximateHyperLogLogIT
phoenix.end2end.SequenceBulkAllocationIT
phoenix.end2end.AlterTableIT
phoenix.end2end.index.GlobalMutableTxIndexIT
phoenix.end2end.LocalIndexSplitMergeIT
phoenix.end2end.PermissionNSEnabledIT
phoenix.end2end.DistinctPrefixFilterIT
phoenix.end2end.DateTimeIT
phoenix.end2end.DropTableWithViewsIT
phoenix.end2end.ParallelIteratorsIT
phoenix.end2end.ArrayPrependFunctionIT
phoenix.end2end.PrimitiveTypeIT
phoenix.end2end.TimezoneOffsetFunctionIT
phoenix.end2end.IndexToolForPartialBuildIT
phoenix.end2end.IndexToolForDeleteBeforeRebuildIT
phoenix.rpc.PhoenixClientRpcIT
phoenix.end2end.join.HashJoinMoreIT
phoenix.end2end.MaxLookbackIT
phoenix.end2end.SpillableGroupByIT
phoenix.end2end.UpsertBigValuesIT
phoenix.end2end.SqrtFunctionEnd2EndIT
phoenix.end2end.TableSnapshotReadsMapReduceIT
phoenix.end2end.TruncateFunctionIT
phoenix.end2end.join.HashJoinGlobalIndexIT
phoenix.end2end.MergeViewIndexIdSequencesToolIT
phoenix.end2end.index.AlterIndexIT
phoenix.end2end.ArrayToStringFunctionIT
phoenix.end2end.LnLogFunctionEnd2EndIT
phoenix.end2end.MultiCfQueryExecIT
phoenix.end2end.OrderByWithServerMemoryLimitIT
phoenix.end2end.PercentileIT
phoenix.end2end.index.DropColumnIT
phoenix.end2end.InstrFunctionIT
phoenix.rpc.PhoenixServerRpcIT
phoenix.end2end.ColumnProjectionOptimizationIT
phoenix.end2end.SignFunctionEnd2EndIT
phoenix.end2end.QueryWithLimitIT
phoenix.end2end.UpsertWithSCNIT
phoenix.end2end.AlterAddCascadeIndexIT
phoenix.end2end.MD5FunctionIT
phoenix.iterate.ChunkedResultIteratorIT
phoenix.end2end.TenantIdTypeIT
phoenix.end2end.index.MutableIndexIT
phoenix.end2end.IndexScrutinyToolForTenantIT
phoenix.end2end.CsvBulkLoadToolIT
phoenix.end2end.index.PartialIndexRebuilderIT
phoenix.end2end.ConcurrentMutationsIT
phoenix.end2end.join.SubqueryUsingSortMergeJoinIT
phoenix.end2end.index.LocalIndexIT
phoenix.end2end.ParameterizedIndexUpgradeToolIT
phoenix.coprocessor.StatisticsCollectionRunTrackerIT
hadoop.hbase.regionserver.wal.WALRecoveryRegionPostOpenIT
phoenix.end2end.salted.SaltedTableIT
phoenix.end2end.ModulusExpressionIT
phoenix.end2end.salted.SaltedTableUpsertSelectIT
phoenix.end2end.ViewMetadataIT
phoenix.end2end.join.HashJoinCacheIT
phoenix.end2end.RegexBulkLoadToolIT
phoenix.end2end.UserDefinedFunctionsIT
phoenix.end2end.CoalesceFunctionIT
phoenix.end2end.PointInTimeQueryIT
phoenix.end2end.QueryDatabaseMetaDataIT
phoenix.end2end.SkipScanAfterManualSplitIT
phoenix.end2end.UngroupedIT
phoenix.end2end.index.txn.RollbackIT
phoenix.end2end.salted.SaltedTableVarLengthRowKeyIT
phoenix.end2end.DistinctCountIT
phoenix.end2end.LogicalTableNameExtendedIT
phoenix.trace.PhoenixTableMetricsWriterIT
phoenix.monitoring.PhoenixMetricsIT
phoenix.end2end.index.MutableIndexFailureIT
phoenix.end2end.ExplainPlanWithStatsEnabledIT
phoenix.execute.PartialCommitIT
phoenix.end2end.index.GlobalImmutableTxIndexIT
phoenix.end2end.QueryLoggerIT
phoenix.end2end.DefaultColumnValueIT
phoenix.end2end.UpsertValuesIT
phoenix.end2end.ConfigurableCacheIT
phoenix.end2end.PermissionsCacheIT
phoenix.schema.stats.NamespaceEnabledStatsCollectorIT
phoenix.end2end.MigrateSystemTablesToSystemNamespaceIT
phoenix.end2end.IndexExtendedIT
phoenix.rpc.UpdateCacheIT
phoenix.end2end.index.SingleCellIndexIT
phoenix.end2end.index.GlobalIndexCheckerIT
phoenix.end2end.DropIndexedColsIT
phoenix.end2end.ConvertTimezoneFunctionIT
phoenix.end2end.EmptyColumnIT
phoenix.end2end.BackwardCompatibilityForSplittableSyscatIT
phoenix.end2end.LastValueFunctionIT
phoenix.end2end.index.ShortViewIndexIdIT
phoenix.end2end.index.LocalMutableNonTxIndexIT
phoenix.end2end.QueryTimeoutIT
phoenix.end2end.UnionAllIT
phoenix.end2end.PartialResultServerConfigurationIT
phoenix.end2end.TenantSpecificTablesDDLIT
phoenix.end2end.WALAnnotationIT
phoenix.end2end.OperationTimeoutWithReasonIT
phoenix.iterate.PhoenixQueryTimeoutIT
phoenix.end2end.index.GlobalIndexOptimizationIT
phoenix.end2end.ConnectionUtilIT
phoenix.end2end.index.PhoenixMRJobSubmitterIT
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
phoenix.iterate.RoundRobinResultIteratorWithStatsIT
phoenix.end2end.index.IndexVerificationOutputRepositoryIT
phoenix.end2end.ArrayRemoveFunctionIT
phoenix.end2end.VariableLengthPKIT
phoenix.end2end.ContextClassloaderIT
phoenix.end2end.ExpFunctionEnd2EndIT
phoenix.end2end.MinMaxAggregateFunctionIT
phoenix.end2end.AlterMultiTenantTableWithViewsIT
phoenix.query.MaxConcurrentConnectionsIT
phoenix.end2end.OrderByWithServerClientSpoolingDisabledIT
phoenix.end2end.join.HashJoinLocalIndexIT
phoenix.end2end.EncodeFunctionIT
phoenix.end2end.index.AsyncIndexDisabledIT
phoenix.end2end.IndexToolTimeRangeIT
phoenix.end2end.NthValueFunctionIT
phoenix.end2end.AppendOnlySchemaIT
phoenix.end2end.ProjectArrayElemAfterHashJoinIT
phoenix.end2end.ExecuteStatementsIT
phoenix.end2end.SpooledTmpFileDeleteIT
phoenix.end2end.LastValuesFunctionIT
phoenix.end2end.EvaluationOfORIT
phoenix.end2end.StoreNullsIT
phoenix.end2end.PhoenixTTLToolIT
phoenix.end2end.OrphanViewToolIT
phoenix.end2end.ReadIsolationLevelIT
phoenix.end2end.IndexToolForNonTxGlobalIndexIT
phoenix.end2end.ReverseFunctionIT
phoenix.end2end.index.txn.TxWriteFailureIT
phoenix.end2end.index.IndexAsyncThresholdIT
phoenix.end2end.IndexToolForPartialBuildWithNamespaceEnabledIT
phoenix.end2end.ViewIT
phoenix.end2end.PhoenixRowTimestampFunctionIT
phoenix.end2end.GroupByIT
phoenix.end2end.OrderByWithSpillingIT
phoenix.end2end.InListIT
phoenix.end2end.ColumnEncodedBytesPropIT
phoenix.end2end.RowValueConstructorIT
phoenix.end2end.ViewTTLIT
phoenix.end2end.ExplainPlanWithStatsDisabledIT
phoenix.end2end.UpdateCacheAcrossDifferentClientsIT
phoenix.end2end.join.SortMergeJoinGlobalIndexIT
phoenix.end2end.BackwardCompatibilityIT
phoenix.end2end.UpgradeNamespaceIT
phoenix.end2end.index.GlobalImmutableNonTxIndexIT
phoenix.end2end.AuditLoggingIT
phoenix.end2end.PartialScannerResultsDisabledIT
phoenix.end2end.index.ChildViewsUseParentViewIndexIT
phoenix.end2end.RowValueConstructorOffsetIT
phoenix.end2end.RowTimestampIT
phoenix.end2end.CastAndCoerceIT
phoenix.end2end.StringToArrayFunctionIT
phoenix.end2end.TenantSpecificViewIndexIT
phoenix.end2end.GetSetByteBitFunctionEnd2EndIT
phoenix.end2end.NoLookbackMutableIndexExtendedIT
phoenix.end2end.IndexBuildTimestampIT
phoenix.schema.stats.NamespaceDisabledStatsCollectorIT
phoenix.rpc.UpdateCacheConnectionLevelPropIT
phoenix.end2end.TenantSpecificViewIndexSaltedIT
phoenix.end2end.ArraysWithNullsIT
phoenix.end2end.KeyOnlyIT
phoenix.end2end.SequenceIT
phoenix.monitoring.PhoenixLoggingMetricsIT
phoenix.end2end.RegexpSubstrFunctionIT
phoenix.end2end.AutoPartitionViewsIT
phoenix.end2end.index.ViewIndexIT
phoenix.end2end.IndexScrutinyToolIT
phoenix.end2end.RoundFloorCeilFuncIT
phoenix.end2end.ConcurrentMutationsExtendedIT
phoenix.tx.TxCheckpointIT
phoenix.end2end.ArrayConcatFunctionIT
phoenix.end2end.join.SortMergeJoinLocalIndexIT
phoenix.end2end.SortOrderIT
phoenix.end2end.CSVCommonsLoaderIT
phoenix.end2end.AbsFunctionEnd2EndIT
phoenix.end2end.StatementHintsIT
phoenix.end2end.BinaryRowKeyIT
phoenix.end2end.IsNullIT
phoenix.end2end.TransactionalViewIT
phoenix.end2end.index.MutableIndexSplitReverseScanIT
phoenix.end2end.FunkyNamesIT
phoenix.end2end.join.SortMergeJoinNoSpoolingIT
phoenix.end2end.RegexpSplitFunctionIT
phoenix.end2end.index.IndexUsageIT
phoenix.end2end.DeleteIT
phoenix.end2end.index.MutableIndexSplitForwardScanIT
phoenix.end2end.join.SubqueryIT
phoenix.end2end.SCNIT
phoenix.end2end.MathTrigFunctionEnd2EndIT
phoenix.end2end.ViewConcurrencyAndFailureIT
phoenix.end2end.QueryMoreIT
phoenix.end2end.SystemCatalogRollbackEnabledIT
phoenix.end2end.FlappingLocalIndexIT
phoenix.end2end.index.ImmutableIndexWithStatsIT
phoenix.end2end.RTrimFunctionIT
phoenix.end2end.index.LocalImmutableNonTxIndexIT
phoenix.end2end.AggregateIT
phoenix.end2end.UpsertSelectIT
phoenix.end2end.PropertiesInSyncIT
phoenix.end2end.index.MutableIndexRebuilderIT
phoenix.end2end.CostBasedDecisionIT
phoenix.end2end.PhoenixRuntimeIT
phoenix.end2end.RowKeyBytesStringFunctionIT
phoenix.end2end.join.HashJoinPersistentCacheIT
phoenix.end2end.IndexRepairRegionScannerIT
phoenix.end2end.OrderByIT
phoenix.end2end.CreateTableIT
phoenix.schema.stats.NoOpStatsCollectorIT
phoenix.end2end.DynamicColumnIT
phoenix.end2end.DateArithmeticIT
phoenix.end2end.PowerFunctionEnd2EndIT
phoenix.end2end.UpgradeIT
phoenix.end2end.LikeExpressionIT
phoenix.end2end.Array2IT
phoenix.end2end.DropSchemaIT
phoenix.tx.FlappingTransactionIT
phoenix.end2end.SystemTablesCreationOnConnectionIT
phoenix.end2end.DropTableIT
phoenix.end2end.Array3IT
phoenix.end2end.ArrayFillFunctionIT
phoenix.end2end.index.txn.MutableRollbackIT
phoenix.end2end.index.IndexMaintenanceIT
phoenix.end2end.UpsertSelectAutoCommitIT
phoenix.execute.UpsertSelectOverlappingBatchesIT
phoenix.end2end.Array1IT
phoenix.end2end.index.ImmutableIndexIT
phoenix.end2end.MapReduceIT
phoenix.end2end.index.GlobalMutableNonTxIndexIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1232
Optional Testsdupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
unameLinux 26206f94d47d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 318a32f
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/2/artifact/yetus-general-check/output/new-spotbugs-root.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/2/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/2/testReport/
asflicensehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count5736 (vs. ulimit of 30000)
modulesC: phoenix-core . U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented May 14, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 5 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep5m 8sMaven dependency ordering for branch
+1 💚mvninstall12m 6smaster passed
+0hbaserecompile24m 14sHBase recompiled.
+1 💚compile1m 35smaster passed
+1 💚checkstyle2m 22smaster passed
+1 💚javadoc2m 16smaster passed
+0 🆗spotbugs5m 7sroot in master has 1029 extant spotbugs warnings.
+0 🆗spotbugs3m 16sphoenix-core in master has 965 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall8m 17sthe patch passed
+0hbaserecompile15m 13sHBase recompiled.
+1 💚compile1m 31sthe patch passed
+1 💚javac1m 31sthe patch passed
-1 ❌checkstyle3m 18sroot: The patch generated 339 new + 5858 unchanged - 6 fixed = 6197 total (was 5864)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc2m 15sthe patch passed
-1 ❌spotbugs3m 19sphoenix-core generated 4 new + 965 unchanged - 0 fixed = 969 total (was 965)
-1 ❌spotbugs4m 48sroot generated 4 new + 1029 unchanged - 0 fixed = 1033 total (was 1029)
_ Other Tests _
-1 ❌unit114m 43sroot in the patch failed.
-1 ❌asflicense1m 53sThe patch generated 614 ASF License warnings.
190m 52s
ReasonTests
FindBugsmodule:phoenix-core
org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 76]
new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 42]
org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
FindBugsmodule:root
org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 76]
new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 42]
org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
Failed junit testsphoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1232
Optional Testsdupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
unameLinux 7b45d9d4e1a0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / eeebc8e
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/3/artifact/yetus-general-check/output/new-spotbugs-root.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/3/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/3/testReport/
asflicensehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count15553 (vs. ulimit of 30000)
modulesC: phoenix-core . U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/3/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented May 19, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 6 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep5m 37sMaven dependency ordering for branch
+1 💚mvninstall11m 12smaster passed
+0hbaserecompile24m 12sHBase recompiled.
+1 💚compile1m 29smaster passed
+1 💚checkstyle3m 7smaster passed
+1 💚javadoc2m 15smaster passed
+0 🆗spotbugs4m 23sroot in master has 1029 extant spotbugs warnings.
+0 🆗spotbugs3m 6sphoenix-core in master has 965 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall8m 17sthe patch passed
+0hbaserecompile14m 56sHBase recompiled.
+1 💚compile1m 29sthe patch passed
+1 💚javac1m 29sthe patch passed
-1 ❌checkstyle3m 18sroot: The patch generated 339 new + 5883 unchanged - 6 fixed = 6222 total (was 5889)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚javadoc2m 13sthe patch passed
-1 ❌spotbugs3m 17sphoenix-core generated 4 new + 965 unchanged - 0 fixed = 969 total (was 965)
-1 ❌spotbugs4m 45sroot generated 4 new + 1029 unchanged - 0 fixed = 1033 total (was 1029)
_ Other Tests _
-1 ❌unit126m 53sroot in the patch failed.
-1 ❌asflicense0m 49sThe patch generated 614 ASF License warnings.
198m 53s
ReasonTests
FindBugsmodule:phoenix-core
org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 76]
new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 42]
org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
FindBugsmodule:root
org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 76]
new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 42]
org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
Failed junit testsphoenix.pherf.PherfMainIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1232
Optional Testsdupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
unameLinux fe3b4b52fccb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 3231aad
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/4/artifact/yetus-general-check/output/new-spotbugs-root.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/4/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/4/testReport/
asflicensehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/4/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count14390 (vs. ulimit of 30000)
modulesC: phoenix-core . U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/4/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented May 20, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 6 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep5m 52sMaven dependency ordering for branch
+1 💚mvninstall12m 12smaster passed
+0hbaserecompile26m 12sHBase recompiled.
+1 💚compile1m 29smaster passed
+1 💚checkstyle3m 5smaster passed
+1 💚javadoc2m 10smaster passed
+0 🆗spotbugs4m 32sroot in master has 1029 extant spotbugs warnings.
+0 🆗spotbugs3m 0sphoenix-core in master has 965 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall8m 7sthe patch passed
+0hbaserecompile14m 56sHBase recompiled.
+1 💚compile1m 30sthe patch passed
+1 💚javac1m 30sthe patch passed
-1 ❌checkstyle3m 19sroot: The patch generated 369 new + 5853 unchanged - 36 fixed = 6222 total (was 5889)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc2m 8sthe patch passed
-1 ❌spotbugs3m 20sphoenix-core generated 4 new + 965 unchanged - 0 fixed = 969 total (was 965)
-1 ❌spotbugs4m 41sroot generated 4 new + 1029 unchanged - 0 fixed = 1033 total (was 1029)
_ Other Tests _
-1 ❌unit112m 48sroot in the patch failed.
-1 ❌asflicense1m 47sThe patch generated 614 ASF License warnings.
189m 48s
ReasonTests
FindBugsmodule:phoenix-core
org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 76]
new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 42]
org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
FindBugsmodule:root
org.apache.phoenix.monitoring.LatencyHistogram.DEFAULT_RANGE should be package protected At LatencyHistogram.java: At LatencyHistogram.java:[line 32]
org.apache.phoenix.monitoring.RangeHistogram.getRanges() may expose internal representation by returning RangeHistogram.ranges At RangeHistogram.java:by returning RangeHistogram.ranges At RangeHistogram.java:[line 76]
new org.apache.phoenix.monitoring.RangeHistogram(long[], String, String) may expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:expose internal representation by storing an externally mutable object into RangeHistogram.ranges At RangeHistogram.java:[line 42]
org.apache.phoenix.monitoring.SizeHistogram.DEFAULT_RANGE should be both final and package protected At SizeHistogram.java:and package protected At SizeHistogram.java:[line 32]
Failed junit testsphoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1232
Optional Testsdupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
unameLinux 30188ca4fa30 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 3231aad
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/5/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/5/artifact/yetus-general-check/output/new-spotbugs-root.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/5/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/5/testReport/
asflicensehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/5/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count15530 (vs. ulimit of 30000)
modulesC: phoenix-core . U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1232/5/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@yanxinyi
yanxinyi merged commit 54cfbca into apache:masterOct 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmeka2020@stoty@yanxinyi