Skip to content

PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use … - #1242

Merged
richardantal merged 1 commit into
apache:4.xfrom
richardantal:PHOENIX-6378-4.x
Jun 8, 2021
Merged

PHOENIX-6378 Unbunldle sqqline from phoenix-client-embedded, and use …#1242
richardantal merged 1 commit into
apache:4.xfrom
richardantal:PHOENIX-6378-4.x

Conversation

@richardantal

Copy link
Copy Markdown
Contributor

…it in sqlline.py

Change-Id: Ifd31e25b303ab3d2872b53f4a503219539777544

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 31sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+0 🆗mvndep5m 30sMaven dependency ordering for branch
+1 💚mvninstall10m 52s4.x passed
+1 💚compile2m 4s4.x passed
+1 💚javadoc1m 59s4.x passed
_ Patch Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for patch
-1 ❌mvninstall7m 29sroot in the patch failed.
-1 ❌compile2m 6sroot in the patch failed.
-1 ❌javac2m 6sroot in the patch failed.
-1 ❌pylint0m 11sThe patch generated 22 new + 112 unchanged - 13 fixed = 134 total (was 125)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 10sThe patch has no ill-formed XML file.
-1 ❌javadoc1m 36sroot in the patch failed.
-1 ❌javadoc0m 12sphoenix-assembly in the patch failed.
_ Other Tests _
-1 ❌unit161m 1sroot in the patch failed.
+1 💚asflicense0m 30sThe patch does not generate ASF License warnings.
200m 52s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1242
Optional Testsdupname asflicense pylint javac javadoc unit xml compile
unameLinux 6c8f872f3f2f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / d0c5627
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstallhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-compile-root.txt
javachttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-compile-root.txt
pylinthttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/diff-patch-pylint.txt
javadochttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-javadoc-root.txt
javadochttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/testReport/
Max. process+thread count5503 (vs. ulimit of 30000)
modulesC: phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/1/console
versionsgit=2.7.4 maven=3.3.9 pylint=2.4.4
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…it in sqlline.py
Change-Id: Ifd31e25b303ab3d2872b53f4a503219539777544
@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+0 🆗mvndep5m 11sMaven dependency ordering for branch
+1 💚mvninstall9m 17s4.x passed
+1 💚compile1m 32s4.x passed
+1 💚javadoc1m 31s4.x passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
-1 ❌mvninstall5m 36sroot in the patch failed.
-1 ❌compile1m 27sroot in the patch failed.
-1 ❌javac1m 27sroot in the patch failed.
-1 ❌pylint0m 8sThe patch generated 22 new + 112 unchanged - 13 fixed = 134 total (was 125)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 8sThe patch has no ill-formed XML file.
-1 ❌javadoc1m 10sroot in the patch failed.
-1 ❌javadoc0m 9sphoenix-assembly in the patch failed.
_ Other Tests _
-1 ❌unit153m 16sroot in the patch failed.
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
182m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1242
Optional Testsdupname asflicense pylint javac javadoc unit xml compile
unameLinux cf582dff551e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / d0c5627
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstallhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-compile-root.txt
javachttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-compile-root.txt
pylinthttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/diff-patch-pylint.txt
javadochttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-javadoc-root.txt
javadochttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/testReport/
Max. process+thread count5683 (vs. ulimit of 30000)
modulesC: phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/2/console
versionsgit=2.7.4 maven=3.3.9 pylint=2.4.4
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+0 🆗mvndep5m 20sMaven dependency ordering for branch
+1 💚mvninstall11m 25s4.x passed
+1 💚compile2m 4s4.x passed
+1 💚javadoc1m 50s4.x passed
_ Patch Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for patch
-1 ❌mvninstall8m 5sroot in the patch failed.
-1 ❌compile1m 57sroot in the patch failed.
-1 ❌javac1m 57sroot in the patch failed.
-1 ❌pylint0m 11sThe patch generated 22 new + 112 unchanged - 13 fixed = 134 total (was 125)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 10sThe patch has no ill-formed XML file.
-1 ❌javadoc1m 29sroot in the patch failed.
-1 ❌javadoc0m 11sphoenix-assembly in the patch failed.
_ Other Tests _
-1 ❌unit171m 46sroot in the patch failed.
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
207m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1242
Optional Testsdupname asflicense pylint javac javadoc unit xml compile
unameLinux dd69f7c82397 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / d0c5627
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstallhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-compile-root.txt
javachttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-compile-root.txt
pylinthttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/diff-patch-pylint.txt
javadochttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-javadoc-root.txt
javadochttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/testReport/
Max. process+thread count5871 (vs. ulimit of 30000)
modulesC: phoenix-client-parent/phoenix-client-embedded . phoenix-assembly U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1242/3/console
versionsgit=2.7.4 maven=3.3.9 pylint=2.4.4
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@richardantal

Copy link
Copy Markdown
ContributorAuthor

Built it locally and run a smoke test with sqlline.py

@richardantal
richardantal requested a review from stotyJune 7, 2021 14:27
@richardantal
richardantal merged commit eb8a91e into apache:4.xJun 8, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@richardantal@stoty