Skip to content

PHOENIX-6504 Restrict thirdparty guava imports to prevent RegionServer crash - #1260

Merged
virajjasani merged 2 commits into
apache:4.16from
virajjasani:PHOENIX-6504-4.16
Jul 7, 2021
Merged

PHOENIX-6504 Restrict thirdparty guava imports to prevent RegionServer crash#1260
virajjasani merged 2 commits into
apache:4.16from
virajjasani:PHOENIX-6504-4.16

Conversation

@virajjasani

Copy link
Copy Markdown
Contributor

No description provided.

@virajjasanivirajjasani changed the title PHOENIX-6504 Ban thirdparty guava imports to prevent RegionServer crashPHOENIX-6504 Restrict thirdparty guava imports to prevent RegionServer crashJul 5, 2021
@stoty

stoty commented Jul 5, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.16 Compile Tests _
+0 🆗mvndep5m 36sMaven dependency ordering for branch
+1 💚mvninstall13m 42s4.16 passed
+1 💚compile2m 35s4.16 passed
+1 💚checkstyle0m 59s4.16 passed
+1 💚javadoc2m 30s4.16 passed
+0 🆗spotbugs6m 10sroot in 4.16 has 999 extant spotbugs warnings.
+0 🆗spotbugs3m 20sphoenix-core in 4.16 has 944 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall13m 26sthe patch passed
+1 💚compile2m 30sthe patch passed
+1 💚javac2m 30sthe patch passed
+1 💚checkstyle0m 57sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc2m 25sthe patch passed
+1 💚spotbugs10m 35sthe patch passed
_ Other Tests _
-1 ❌unit153m 47sroot in the patch failed.
+1 💚asflicense0m 20sThe patch does not generate ASF License warnings.
221m 18s
ReasonTests
Failed junit testsphoenix.pherf.PherfMainIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1260/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1260
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml
unameLinux c37892eb8204 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.16 / 49ff48a
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1260/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1260/1/testReport/
Max. process+thread count5661 (vs. ulimit of 30000)
modulesC: phoenix-core . U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1260/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Jul 5, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.16 Compile Tests _
+0 🆗mvndep5m 17sMaven dependency ordering for branch
+1 💚mvninstall13m 23s4.16 passed
+1 💚compile1m 47s4.16 passed
+1 💚checkstyle0m 49s4.16 passed
+1 💚javadoc1m 57s4.16 passed
+0 🆗spotbugs4m 23sroot in 4.16 has 999 extant spotbugs warnings.
+0 🆗spotbugs2m 55sphoenix-core in 4.16 has 944 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall9m 50sthe patch passed
+1 💚compile1m 45sthe patch passed
+1 💚javac1m 45sthe patch passed
+1 💚checkstyle0m 50sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc1m 54sthe patch passed
+1 💚spotbugs7m 47sthe patch passed
_ Other Tests _
-1 ❌unit149m 9sroot in the patch failed.
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
204m 25s
ReasonTests
Failed junit testsphoenix.pherf.PherfMainIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1260/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1260
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml
unameLinux ae455238e7eb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.16 / 49ff48a
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1260/2/artifact/yetus-general-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1260/2/testReport/
Max. process+thread count5975 (vs. ulimit of 30000)
modulesC: phoenix-core . U: .
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1260/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Comment threadpom.xml Outdated
</restrictImports>
<restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">
<includeTestCode>true</includeTestCode>
<reason>Do not use phoenix-thirdparty provided Guava</reason>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe emphasise that's it's for 4.x only.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense. Thanks

@virajjasani
virajjasani merged commit c74ebc0 into apache:4.16Jul 7, 2021
@virajjasani
virajjasani deleted the PHOENIX-6504-4.16 branch July 7, 2021 06:29
virajjasani added a commit that referenced this pull request Jul 7, 2021
…r crash (#1260)
Signed-off-by: Istvan Toth <stoty@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@virajjasani@stoty